h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 11:42:56 +08:00
Code Issues Releases Wiki Activity

Remove list allocations in UpdateNestedSamples

Browse Source
This commit is contained in:
Dean Herbert 2024-02-18 03:22:10 +08:00
parent 0714a4fc1e
commit 0df6e8f595
No known key found for this signature in database
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
osu.Game.Rulesets.Osu/Objects/Slider.cs
View File

@ -252,20 +252,16 @@ namespace osu.Game.Rulesets.Osu.Objects
protected void UpdateNestedSamples()
{
var firstSample = Samples.FirstOrDefault(s => s.Name == HitSampleInfo.HIT_NORMAL)
?? Samples.FirstOrDefault(); // TODO: remove this when guaranteed sort is present for samples (https://github.com/ppy/osu/issues/1933)
var sampleList = new List<HitSampleInfo>();
if (firstSample != null)
sampleList.Add(firstSample.With("slidertick"));
// TODO: remove this when guaranteed sort is present for samples (https://github.com/ppy/osu/issues/1933)
HitSampleInfo tickSample = (Samples.FirstOrDefault(s => s.Name == HitSampleInfo.HIT_NORMAL) ?? Samples.First()).With("slidertick");
foreach (var nested in NestedHitObjects)
{
switch (nested)
{
case SliderTick tick:
tick.Samples = sampleList;
tick.SamplesBindable.Clear();
tick.SamplesBindable.Add(tickSample);
break;
case SliderRepeat repeat: