h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-11 05:42:58 +08:00
Code Issues Releases Wiki Activity

Improve exception logging of unobserved exceptions via FireAndForget

Browse Source 
Coming from https://github.com/ppy/osu/issues/27076, where the log
output makes finding where the exception arrived for nigh impossible.
This commit is contained in:
Dean Herbert 2024-02-08 00:20:53 +08:00
parent 7460d077f7
commit 0d7e82ab8d
No known key found for this signature in database
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
osu.Game/Online/Multiplayer/MultiplayerClientExtensions.cs
View File

@ -23,9 +23,12 @@ namespace osu.Game.Online.Multiplayer
Debug.Assert(exception != null); Debug.Assert(exception != null);
string message = exception.GetHubExceptionMessage() ?? exception.Message; if (exception.GetHubExceptionMessage() is string message)
// Hub exceptions generally contain something we can show the user directly.
Logger.Log(message, level: LogLevel.Important); Logger.Log(message, level: LogLevel.Important);
else
Logger.Error(exception, $"Unobserved exception occurred via {nameof(FireAndForget)} call: {exception.Message}");
onError?.Invoke(exception); onError?.Invoke(exception);
} }
else else