h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-28 11:02:54 +08:00
Code Issues Releases Wiki Activity

Reduce overhead of ColumnHasObject calls by storing column usage separately

Browse Source
This commit is contained in:
Dean Herbert 2021-09-20 01:48:14 +09:00
parent 801bee7c47
commit 0d58530dbe
1 changed files with 21 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
osu.Game.Rulesets.Mania/Beatmaps/Patterns/Pattern.cs
View File

@ -2,7 +2,6 @@
// See the LICENCE file in the repository root for full licence text. // See the LICENCE file in the repository root for full licence text.
using System.Collections.Generic; using System.Collections.Generic;
using System.Linq;
using osu.Game.Rulesets.Mania.Objects; using osu.Game.Rulesets.Mania.Objects;
namespace osu.Game.Rulesets.Mania.Beatmaps.Patterns namespace osu.Game.Rulesets.Mania.Beatmaps.Patterns
@ -14,6 +13,8 @@ namespace osu.Game.Rulesets.Mania.Beatmaps.Patterns
{ {
private readonly List<ManiaHitObject> hitObjects = new List<ManiaHitObject>(); private readonly List<ManiaHitObject> hitObjects = new List<ManiaHitObject>();
private readonly HashSet<int> containedColumns = new HashSet<int>();
/// <summary> /// <summary>
/// All the hit objects contained in this pattern. /// All the hit objects contained in this pattern.
/// </summary> /// </summary>
@ -24,34 +25,42 @@ namespace osu.Game.Rulesets.Mania.Beatmaps.Patterns
/// </summary> /// </summary>
/// <param name="column">The column index.</param> /// <param name="column">The column index.</param>
/// <returns>Whether the column with index <paramref name="column"/> contains a hit object.</returns> /// <returns>Whether the column with index <paramref name="column"/> contains a hit object.</returns>
public bool ColumnHasObject(int column) => hitObjects.Exists(h => h.Column == column); public bool ColumnHasObject(int column) => containedColumns.Contains(column);
/// <summary> /// <summary>
/// Amount of columns taken up by hit objects in this pattern. /// Amount of columns taken up by hit objects in this pattern.
/// </summary> /// </summary>
public int ColumnWithObjects => HitObjects.GroupBy(h => h.Column).Count(); public int ColumnWithObjects => containedColumns.Count;
/// <summary> /// <summary>
/// Adds a hit object to this pattern. /// Adds a hit object to this pattern.
/// </summary> /// </summary>
/// <param name="hitObject">The hit object to add.</param> /// <param name="hitObject">The hit object to add.</param>
public void Add(ManiaHitObject hitObject) => hitObjects.Add(hitObject); public void Add(ManiaHitObject hitObject)
{
hitObjects.Add(hitObject);
containedColumns.Add(hitObject.Column);
}
/// <summary> /// <summary>
/// Copies hit object from another pattern to this one. /// Copies hit object from another pattern to this one.
/// </summary> /// </summary>
/// <param name="other">The other pattern.</param> /// <param name="other">The other pattern.</param>
public void Add(Pattern other) => hitObjects.AddRange(other.HitObjects); public void Add(Pattern other)
{
hitObjects.AddRange(other.HitObjects);
foreach (var h in other.hitObjects)
containedColumns.Add(h.Column);
}
/// <summary> /// <summary>
/// Clears this pattern, removing all hit objects. /// Clears this pattern, removing all hit objects.
/// </summary> /// </summary>
public void Clear() => hitObjects.Clear(); public void Clear()
{
/// <summary> hitObjects.Clear();
/// Removes a hit object from this pattern. containedColumns.Clear();
/// </summary> }
/// <param name="hitObject">The hit object to remove.</param>
public bool Remove(ManiaHitObject hitObject) => hitObjects.Remove(hitObject);
} }
} }