h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-30 08:52:58 +08:00
Code Issues Releases Wiki Activity

Merge pull request #1775 from peppy/fix-progress-notifications-close

Browse Source 
Fix progress notifications not creating their completion notification early enough
This commit is contained in:
Dean Herbert 2017-12-27 22:58:19 +09:00 committed by GitHub
commit 0d3b11a1a0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
osu.Game/Overlays/NotificationOverlay.cs
View File

@ -85,9 +85,12 @@ namespace osu.Game.Overlays
private void notificationClosed() private void notificationClosed()
{ {
// hide ourselves if all notifications have been dismissed. Schedule(() =>
if (totalCount == 0) {
State = Visibility.Hidden; // hide ourselves if all notifications have been dismissed.
if (totalCount == 0)
State = Visibility.Hidden;
});
updateCounts(); updateCounts();
} }

2
osu.Game/Overlays/Notifications/ProgressNotification.cs
View File

@ -95,8 +95,8 @@ namespace osu.Game.Overlays.Notifications
protected virtual void Completed() protected virtual void Completed()
{ {
base.Close();
CompletionTarget?.Invoke(CreateCompletionNotification()); CompletionTarget?.Invoke(CreateCompletionNotification());
base.Close();
} }
public override bool DisplayOnTop => false; public override bool DisplayOnTop => false;