h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-06 07:42:55 +08:00
Code Issues Releases Wiki Activity

Adjust existing test coverage to pass

Browse Source
This commit is contained in:
Bartłomiej Dach 2022-02-06 17:56:51 +01:00
parent a2c2b2bbb3
commit 0d1171b7fa
No known key found for this signature in database
GPG Key ID: BCECCD4FA41F6497
1 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
osu.Game.Tests/Visual/Editing/TestSceneEditorBeatmapCreation.cs
View File

@ -10,6 +10,7 @@ using osu.Framework.Screens;
using osu.Framework.Testing; using osu.Framework.Testing;
using osu.Game.Beatmaps; using osu.Game.Beatmaps;
using osu.Game.Rulesets; using osu.Game.Rulesets;
using osu.Game.Rulesets.Catch;
using osu.Game.Rulesets.Osu; using osu.Game.Rulesets.Osu;
using osu.Game.Screens.Edit; using osu.Game.Screens.Edit;
using osu.Game.Screens.Edit.Setup; using osu.Game.Screens.Edit.Setup;
@ -92,7 +93,7 @@ namespace osu.Game.Tests.Visual.Editing
} }
[Test] [Test]
public void TestCreateNewDifficulty() public void TestCreateNewDifficulty([Values] bool sameRuleset)
{ {
string firstDifficultyName = Guid.NewGuid().ToString(); string firstDifficultyName = Guid.NewGuid().ToString();
string secondDifficultyName = Guid.NewGuid().ToString(); string secondDifficultyName = Guid.NewGuid().ToString();
@ -111,7 +112,14 @@ namespace osu.Game.Tests.Visual.Editing
}); });
AddAssert("can save again", () => Editor.Save()); AddAssert("can save again", () => Editor.Save());
AddStep("create new difficulty", () => Editor.CreateNewDifficulty(new OsuRuleset().RulesetInfo)); AddStep("create new difficulty", () => Editor.CreateNewDifficulty(sameRuleset ? new OsuRuleset().RulesetInfo : new CatchRuleset().RulesetInfo));
if (sameRuleset)
{
AddUntilStep("wait for dialog", () => DialogOverlay.CurrentDialog is CreateNewDifficultyDialog);
AddStep("confirm creation with no objects", () => DialogOverlay.CurrentDialog.PerformOkAction());
}
AddUntilStep("wait for created", () => AddUntilStep("wait for created", () =>
{ {
string difficultyName = Editor.ChildrenOfType<EditorBeatmap>().SingleOrDefault()?.BeatmapInfo.DifficultyName; string difficultyName = Editor.ChildrenOfType<EditorBeatmap>().SingleOrDefault()?.BeatmapInfo.DifficultyName;
@ -154,7 +162,7 @@ namespace osu.Game.Tests.Visual.Editing
} }
[Test] [Test]
public void TestCreateNewBeatmapFailsWithSameNamedDifficulties() public void TestCreateNewBeatmapFailsWithSameNamedDifficulties([Values] bool sameRuleset)
{ {
Guid setId = Guid.Empty; Guid setId = Guid.Empty;
const string duplicate_difficulty_name = "duplicate"; const string duplicate_difficulty_name = "duplicate";
@ -168,7 +176,14 @@ namespace osu.Game.Tests.Visual.Editing
return set != null && set.PerformRead(s => s.Beatmaps.Count == 1 && s.Files.Count == 1); return set != null && set.PerformRead(s => s.Beatmaps.Count == 1 && s.Files.Count == 1);
}); });
AddStep("create new difficulty", () => Editor.CreateNewDifficulty(new OsuRuleset().RulesetInfo)); AddStep("create new difficulty", () => Editor.CreateNewDifficulty(sameRuleset ? new OsuRuleset().RulesetInfo : new CatchRuleset().RulesetInfo));
if (sameRuleset)
{
AddUntilStep("wait for dialog", () => DialogOverlay.CurrentDialog is CreateNewDifficultyDialog);
AddStep("confirm creation with no objects", () => DialogOverlay.CurrentDialog.PerformOkAction());
}
AddUntilStep("wait for created", () => AddUntilStep("wait for created", () =>
{ {
string difficultyName = Editor.ChildrenOfType<EditorBeatmap>().SingleOrDefault()?.BeatmapInfo.DifficultyName; string difficultyName = Editor.ChildrenOfType<EditorBeatmap>().SingleOrDefault()?.BeatmapInfo.DifficultyName;