Don't break VisualTests and add a real beatmap step.

osu.Game.Tests/Visual/TestCaseLeaderboard.cs

@@ -6,15 +6,43 @@ using osu.Framework.Graphics;
 using osu.Game.Rulesets.Scoring;
 using osu.Game.Screens.Select.Leaderboards;
 using osu.Game.Users;
+using osu.Framework.Allocation;
 using OpenTK;
+using System.Linq;
+using osu.Game.Beatmaps;
+using osu.Game.Rulesets;
 
 namespace osu.Game.Tests.Visual
 {
     [Description("PlaySongSelect leaderboard")]
     internal class TestCaseLeaderboard : OsuTestCase
     {
+        private RulesetStore rulesets;
+
         private readonly Leaderboard leaderboard;
 
+        public TestCaseLeaderboard()
+        {
+            Add(leaderboard = new Leaderboard
+            {
+                Origin = Anchor.Centre,
+                Anchor = Anchor.Centre,
+                Size = new Vector2(550f, 450f),
+                Scope = LeaderboardScope.Global,
+            });
+
+            AddStep(@"New Scores", newScores);
+            AddStep(@"Empty Scores", () => leaderboard.Scores = Enumerable.Empty<Score>());
+            AddStep(@"Real beatmap", realBeatmap);
+            newScores();
+        }
+
+        [BackgroundDependencyLoader]
+        private void load(RulesetStore rulesets)
+        {
+            this.rulesets = rulesets;
+        }
+
         private void newScores()
         {
             var scores = new[]
@@ -204,17 +232,36 @@ namespace osu.Game.Tests.Visual
             leaderboard.Scores = scores;
         }
 
-        public TestCaseLeaderboard()
+        private void realBeatmap()
         {
-            Add(leaderboard = new Leaderboard
+            leaderboard.Beatmap = new BeatmapInfo
             {
-                Origin = Anchor.Centre,
+                StarDifficulty = 1.36,
-                Anchor = Anchor.Centre,
+                Version = @"BASIC",
-                Size = new Vector2(550f, 450f),
+                OnlineBeatmapID = 1113057,
-            });
+                Ruleset = rulesets.GetRuleset(0),
-
+                BaseDifficulty = new BeatmapDifficulty
-            AddStep(@"New Scores", newScores);
+                {
-            newScores();
+                    CircleSize = 4,
+                    DrainRate = 6.5f,
+                    OverallDifficulty = 6.5f,
+                    ApproachRate = 5,
+                },
+                OnlineInfo = new BeatmapOnlineInfo
+                {
+                    Length = 115000,
+                    CircleCount = 265,
+                    SliderCount = 71,
+                    PlayCount = 47906,
+                    PassCount = 19899,
+                },
+                Metrics = new BeatmapMetrics
+                {
+                    Ratings = Enumerable.Range(0, 11),
+                    Fails = Enumerable.Range(1, 100).Select(i => i % 12 - 6),
+                    Retries = Enumerable.Range(-2, 100).Select(i => i % 12 - 6),
+                },
+            };
         }
     }
 }

osu.Game/Screens/Select/Leaderboards/Leaderboard.cs

@@ -51,6 +51,7 @@ namespace osu.Game.Screens.Select.Leaderboards
 
                 noResultsPlaceholder.FadeOut(fade_duration);
                 scrollFlow?.FadeOut(fade_duration).Expire();
+                scrollContainer.Clear(true); // scores stick around in scrollFlow in VisualTests without this for some reason
                 scrollFlow = null;
 
                 loading.Hide();
@@ -204,7 +205,8 @@ namespace osu.Game.Screens.Select.Leaderboards
             this.api = api;
             this.osuGame = osuGame;
 
-            osuGame.Ruleset.ValueChanged += r => updateScores();
+            if (osuGame != null)
+                osuGame.Ruleset.ValueChanged += r => updateScores();
         }
 
         private GetScoresRequest getScoresRequest;
@@ -228,7 +230,7 @@ namespace osu.Game.Screens.Select.Leaderboards
 
             loading.Show();
 
-            getScoresRequest = new GetScoresRequest(Beatmap, osuGame.Ruleset.Value, Scope);
+            getScoresRequest = new GetScoresRequest(Beatmap, osuGame?.Ruleset.Value, Scope);
             getScoresRequest.Success += r =>
             {
                 Scores = r.Scores;