h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-13 17:13:06 +08:00
Code Issues Releases Wiki Activity

Fix list not repopulating on new room

Browse Source
This commit is contained in:
Dan Balasescu 2021-12-01 19:02:17 +09:00
parent a4cd22d5a9
commit 0b3cc47a51
1 changed files with 35 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
osu.Game.Tests/Visual/Multiplayer/TestSceneMultiplayerPlaylist.cs
View File

@ -16,6 +16,7 @@ using osu.Game.Rulesets;
using osu.Game.Screens.OnlinePlay; using osu.Game.Screens.OnlinePlay;
using osu.Game.Screens.OnlinePlay.Multiplayer; using osu.Game.Screens.OnlinePlay.Multiplayer;
using osu.Game.Screens.OnlinePlay.Multiplayer.Match.Playlist; using osu.Game.Screens.OnlinePlay.Multiplayer.Match.Playlist;
using osu.Game.Tests.Beatmaps;
using osu.Game.Tests.Resources; using osu.Game.Tests.Resources;
using osuTK; using osuTK;
@ -131,6 +132,33 @@ namespace osu.Game.Tests.Visual.Multiplayer
{ {
AddStep("leave room", () => RoomManager.PartRoom()); AddStep("leave room", () => RoomManager.PartRoom());
AddUntilStep("wait for room part", () => Client.Room == null); AddUntilStep("wait for room part", () => Client.Room == null);
AddStep("join room with items", () =>
{
RoomManager.CreateRoom(new Room
{
Name = { Value = "test name" },
Playlist =
{
new PlaylistItem
{
Beatmap = { Value = new TestBeatmap(Ruleset.Value).BeatmapInfo },
Ruleset = { Value = Ruleset.Value }
},
new PlaylistItem
{
Beatmap = { Value = new TestBeatmap(Ruleset.Value).BeatmapInfo },
Ruleset = { Value = Ruleset.Value },
Expired = true
}
}
});
});
AddUntilStep("wait for room join", () => RoomJoined);
assertItemInQueueListStep(1, 0);
assertItemInHistoryListStep(2, 0);
} }
/// <summary> /// <summary>
@ -228,15 +256,17 @@ namespace osu.Game.Tests.Visual.Multiplayer
{ {
historyList.Items.Clear(); historyList.Items.Clear();
queueList.Items.Clear(); queueList.Items.Clear();
firstPopulation = true;
return; return;
} }
if (!firstPopulation) return; if (firstPopulation)
{
foreach (var item in Room.Playlist)
PlaylistItemAdded(item);
foreach (var item in Room.Playlist) firstPopulation = false;
PlaylistItemAdded(item); }
firstPopulation = false;
} }
protected override void PlaylistItemAdded(MultiplayerPlaylistItem item) protected override void PlaylistItemAdded(MultiplayerPlaylistItem item)