h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-13 23:53:21 +08:00
Code Issues Releases Wiki Activity

Fix SliderPath.Version bindings not being correctly cleaned up on path changes

Browse Source
This commit is contained in:
Dean Herbert 2022-08-25 15:00:32 +09:00
parent 136dcee3b5
commit 091c51e664
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
osu.Game.Rulesets.Osu/Edit/Blueprints/Sliders/Components/PathControlPointVisualiser.cs
View File

@ -142,8 +142,10 @@ namespace osu.Game.Rulesets.Osu.Edit.Blueprints.Sliders.Components
case NotifyCollectionChangedAction.Remove: case NotifyCollectionChangedAction.Remove:
foreach (var point in e.OldItems.Cast<PathControlPoint>()) foreach (var point in e.OldItems.Cast<PathControlPoint>())
{ {
Pieces.RemoveAll(p => p.ControlPoint == point); foreach (var piece in Pieces.Where(p => p.ControlPoint == point))
Connections.RemoveAll(c => c.ControlPoint == point); piece.RemoveAndDisposeImmediately();
foreach (var connection in Connections.Where(c => c.ControlPoint == point))
connection.RemoveAndDisposeImmediately();
} }
// If removing before the end of the path, // If removing before the end of the path,