1
0
mirror of https://github.com/ppy/osu.git synced 2026-06-07 04:13:38 +08:00

Apply review

This commit is contained in:
Dean Herbert
2018-11-30 18:06:48 +09:00
Unverified
parent 9718e476c7
commit 059e9e180b
4 changed files with 10 additions and 5 deletions
+1
View File
@@ -28,6 +28,7 @@ namespace osu.Game.Beatmaps
set => onlineBeatmapID = value > 0 ? value : null;
}
[JsonIgnore]
public int BeatmapSetInfoID { get; set; }
public BeatmapSetOnlineStatus Status { get; set; } = BeatmapSetOnlineStatus.None;
@@ -119,8 +119,11 @@ namespace osu.Game.Online.API.Requests.Responses
{
base.Ruleset = value;
// Evaluate the mod string
Mods = Ruleset.CreateInstance().GetAllMods().Where(mod => modStrings.Contains(mod.Acronym)).ToArray();
if (modStrings != null)
{
// Evaluate the mod string
Mods = Ruleset.CreateInstance().GetAllMods().Where(mod => modStrings.Contains(mod.Acronym)).ToArray();
}
}
}
}
@@ -9,7 +9,6 @@ using osu.Game.Users;
using System;
using System.Linq;
using osu.Game.Online.API.Requests.Responses;
using osu.Game.Scoring;
namespace osu.Game.Overlays.Profile.Sections.Ranks
{
@@ -30,8 +29,6 @@ namespace osu.Game.Overlays.Profile.Sections.Ranks
ItemsContainer.Direction = FillDirection.Vertical;
}
private ScoreManager scoreManager;
protected override void ShowMore()
{
base.ShowMore();
+4
View File
@@ -75,6 +75,7 @@ namespace osu.Game.Scoring
}
}
[JsonIgnore]
public User User;
[Column("User")]
@@ -84,6 +85,7 @@ namespace osu.Game.Scoring
set => User = new User { Username = value };
}
[JsonIgnore]
public int BeatmapInfoID { get; set; }
public virtual BeatmapInfo Beatmap { get; set; }
@@ -92,6 +94,7 @@ namespace osu.Game.Scoring
public DateTimeOffset Date { get; set; }
[JsonIgnore]
public Dictionary<HitResult, object> Statistics = new Dictionary<HitResult, object>();
[Column("Statistics")]
@@ -110,6 +113,7 @@ namespace osu.Game.Scoring
}
}
[JsonIgnore]
public List<ScoreFileInfo> Files { get; set; }
public string Hash { get; set; }