From 050bf9ec6033b26a4a0cb6878738dc66346ba0b7 Mon Sep 17 00:00:00 2001
From: Salman Alshamrani <frenzibyte@gmail.com>
Date: Mon, 23 Dec 2024 10:52:18 -0500
Subject: [PATCH] Keep 'x' symbol visible even while disabled

---
 ...BeatmapSearchMultipleSelectionFilterRow.cs | 20 ++++---------------
 1 file changed, 4 insertions(+), 16 deletions(-)

diff --git a/osu.Game/Overlays/BeatmapListing/BeatmapSearchMultipleSelectionFilterRow.cs b/osu.Game/Overlays/BeatmapListing/BeatmapSearchMultipleSelectionFilterRow.cs
index 27b630d623..b4940d3aa1 100644
--- a/osu.Game/Overlays/BeatmapListing/BeatmapSearchMultipleSelectionFilterRow.cs
+++ b/osu.Game/Overlays/BeatmapListing/BeatmapSearchMultipleSelectionFilterRow.cs
@@ -107,7 +107,6 @@ namespace osu.Game.Overlays.BeatmapListing
         {
             private Container activeContent = null!;
             private Circle background = null!;
-            private SpriteIcon icon = null!;
 
             public MultipleSelectionFilterTabItem(T value)
                 : base(value)
@@ -129,6 +128,7 @@ namespace osu.Game.Overlays.BeatmapListing
                     Alpha = 0,
                     Padding = new MarginPadding
                     {
+                        Left = -16,
                         Right = -4,
                         Vertical = -2
                     },
@@ -139,9 +139,8 @@ namespace osu.Game.Overlays.BeatmapListing
                             Colour = Color4.White,
                             RelativeSizeAxes = Axes.Both,
                         },
-                        icon = new SpriteIcon
+                        new SpriteIcon
                         {
-                            Alpha = 0f,
                             Icon = FontAwesome.Solid.TimesCircle,
                             Size = new Vector2(10),
                             Colour = ColourProvider.Background4,
@@ -173,19 +172,8 @@ namespace osu.Game.Overlays.BeatmapListing
 
                 if (Active.Value)
                 {
-                    if (Enabled.Value)
-                    {
-                        // This just allows enough spacing for adjacent tab items to show the "x".
-                        Padding = new MarginPadding { Left = 12 };
-                        activeContent.Padding = activeContent.Padding with { Left = -16 };
-                        icon.Show();
-                    }
-                    else
-                    {
-                        Padding = new MarginPadding();
-                        activeContent.Padding = activeContent.Padding with { Left = -4 };
-                        icon.Hide();
-                    }
+                    // This just allows enough spacing for adjacent tab items to show the "x".
+                    Padding = new MarginPadding { Left = 12 };
 
                     activeContent.FadeIn(200, Easing.OutQuint);
                     background.FadeColour(colour, 200, Easing.OutQuint);