h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-05 10:33:22 +08:00
Code Issues Releases Wiki Activity

Move non-legacy conditional reasoning to migration code

Browse Source
This commit is contained in:
Salman Alshamrani 2024-11-27 06:12:49 -05:00
parent 0e920a61da
commit 01f3a2dd14
2 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
osu.Game.Tests/Skins/TestSceneSkinMigration.cs
View File

@ -199,13 +199,6 @@ namespace osu.Game.Tests.Skins
}); });
}); });
// One may argue that if a LegacyHealthDisplay exists in a non-legacy skin,
// then it should be swapped with the mania variant similar to legacy skins.
// This is not simple to achieve as we have to be aware of the presence of
// the health display in the HUD layout while migrating the Playfield layout,
// which is impossible with the current structure of skin layout migration.
// Instead, don't touch any non-legacy skin and call it a day.
// HUD // HUD
AddAssert("health display still in global HUD", () => AddAssert("health display still in global HUD", () =>
{ {

8
osu.Game/Skinning/Skin.cs
View File

@ -343,7 +343,15 @@ namespace osu.Game.Skinning
case GlobalSkinnableContainers.Playfield: case GlobalSkinnableContainers.Playfield:
if (!isLegacySkin) if (!isLegacySkin)
{
// One may argue that if a LegacyHealthDisplay exists in a non-legacy skin,
// then it should be swapped with the mania variant similar to legacy skins.
// This is not simple to achieve as we have to be aware of the presence of
// the health display in the HUD layout while migrating the Playfield layout,
// which is impossible with the current structure of skin layout migration.
// Instead, don't touch any non-legacy skin and call it a day.
break; break;
}
resources.RealmAccess.Run(r => resources.RealmAccess.Run(r =>
{ {