From 01219fa3712f46ea55c0df150c2c3be2c0a31a48 Mon Sep 17 00:00:00 2001
From: Salman Ahmed <frenzibyte@gmail.com>
Date: Sat, 30 Dec 2023 05:16:41 +0300
Subject: [PATCH] Disable "closest" anchor in mania combo counter for
 convenience

---
 osu.Game/Overlays/SkinEditor/SkinEditor.cs           | 3 +++
 osu.Game/Overlays/SkinEditor/SkinSelectionHandler.cs | 3 ++-
 osu.Game/Skinning/ISerialisableDrawable.cs           | 8 ++++++++
 3 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/osu.Game/Overlays/SkinEditor/SkinEditor.cs b/osu.Game/Overlays/SkinEditor/SkinEditor.cs
index f972186333..cc1e5b26ec 100644
--- a/osu.Game/Overlays/SkinEditor/SkinEditor.cs
+++ b/osu.Game/Overlays/SkinEditor/SkinEditor.cs
@@ -441,6 +441,9 @@ namespace osu.Game.Overlays.SkinEditor
                 drawableComponent.Origin = Anchor.TopCentre;
                 drawableComponent.Anchor = Anchor.TopCentre;
                 drawableComponent.Y = targetContainer.DrawSize.Y / 2;
+
+                if (!component.SupportsClosestAnchor)
+                    component.UsesFixedAnchor = true;
             }
 
             try
diff --git a/osu.Game/Overlays/SkinEditor/SkinSelectionHandler.cs b/osu.Game/Overlays/SkinEditor/SkinSelectionHandler.cs
index cf6fb60636..208bd71005 100644
--- a/osu.Game/Overlays/SkinEditor/SkinSelectionHandler.cs
+++ b/osu.Game/Overlays/SkinEditor/SkinSelectionHandler.cs
@@ -233,7 +233,8 @@ namespace osu.Game.Overlays.SkinEditor
         {
             var closestItem = new TernaryStateRadioMenuItem("Closest", MenuItemType.Standard, _ => applyClosestAnchors())
             {
-                State = { Value = GetStateFromSelection(selection, c => !c.Item.UsesFixedAnchor) }
+                State = { Value = GetStateFromSelection(selection, c => !c.Item.UsesFixedAnchor), },
+                Action = { Disabled = selection.Any(c => !c.Item.SupportsClosestAnchor) },
             };
 
             yield return new OsuMenuItem("Anchor")
diff --git a/osu.Game/Skinning/ISerialisableDrawable.cs b/osu.Game/Skinning/ISerialisableDrawable.cs
index c9dcaca6d1..898186bcc1 100644
--- a/osu.Game/Skinning/ISerialisableDrawable.cs
+++ b/osu.Game/Skinning/ISerialisableDrawable.cs
@@ -27,6 +27,14 @@ namespace osu.Game.Skinning
         /// </summary>
         bool IsEditable => true;
 
+        /// <summary>
+        /// Whether this component supports the "closest" anchor.
+        /// </summary>
+        /// <remarks>
+        /// This is disabled by some components that shift position automatically.
+        /// </remarks>
+        bool SupportsClosestAnchor => true;
+
         /// <summary>
         /// In the context of the skin layout editor, whether this <see cref="ISerialisableDrawable"/> has a permanent anchor defined.
         /// If <see langword="false"/>, this <see cref="ISerialisableDrawable"/>'s <see cref="Drawable.Anchor"/> is automatically determined by proximity,