mirror of
https://github.com/ppy/osu.git
synced 2025-02-21 20:12:57 +08:00
Merge branch 'master' into editor-grids-2
This commit is contained in:
commit
00f0957cc3
25
build.ps1
25
build.ps1
@ -1,4 +1,27 @@
|
|||||||
|
[CmdletBinding()]
|
||||||
|
Param(
|
||||||
|
[string]$Target,
|
||||||
|
[string]$Configuration,
|
||||||
|
[ValidateSet("Quiet", "Minimal", "Normal", "Verbose", "Diagnostic")]
|
||||||
|
[string]$Verbosity,
|
||||||
|
[switch]$ShowDescription,
|
||||||
|
[Alias("WhatIf", "Noop")]
|
||||||
|
[switch]$DryRun,
|
||||||
|
[Parameter(Position = 0, Mandatory = $false, ValueFromRemainingArguments = $true)]
|
||||||
|
[string[]]$ScriptArgs
|
||||||
|
)
|
||||||
|
|
||||||
|
# Build Cake arguments
|
||||||
|
$cakeArguments = "";
|
||||||
|
if ($Target) { $cakeArguments += "-target=$Target" }
|
||||||
|
if ($Configuration) { $cakeArguments += "-configuration=$Configuration" }
|
||||||
|
if ($Verbosity) { $cakeArguments += "-verbosity=$Verbosity" }
|
||||||
|
if ($ShowDescription) { $cakeArguments += "-showdescription" }
|
||||||
|
if ($DryRun) { $cakeArguments += "-dryrun" }
|
||||||
|
if ($Experimental) { $cakeArguments += "-experimental" }
|
||||||
|
$cakeArguments += $ScriptArgs
|
||||||
|
|
||||||
dotnet tool install Cake.Tool --global --version 0.35.0
|
dotnet tool install Cake.Tool --global --version 0.35.0
|
||||||
dotnet cake ./build/build.cake --bootstrap
|
dotnet cake ./build/build.cake --bootstrap
|
||||||
dotnet cake ./build/build.cake
|
dotnet cake ./build/build.cake $cakeArguments
|
||||||
exit $LASTEXITCODE
|
exit $LASTEXITCODE
|
16
build.sh
16
build.sh
@ -1,3 +1,17 @@
|
|||||||
|
echo "Installing Cake.Tool..."
|
||||||
dotnet tool install Cake.Tool --global --version 0.35.0
|
dotnet tool install Cake.Tool --global --version 0.35.0
|
||||||
|
|
||||||
|
# Parse arguments.
|
||||||
|
CAKE_ARGUMENTS=()
|
||||||
|
for i in "$@"; do
|
||||||
|
case $1 in
|
||||||
|
-s|--script) SCRIPT="$2"; shift ;;
|
||||||
|
--) shift; CAKE_ARGUMENTS+=("$@"); break ;;
|
||||||
|
*) CAKE_ARGUMENTS+=("$1") ;;
|
||||||
|
esac
|
||||||
|
shift
|
||||||
|
done
|
||||||
|
|
||||||
|
echo "Running build script..."
|
||||||
dotnet cake ./build/build.cake --bootstrap
|
dotnet cake ./build/build.cake --bootstrap
|
||||||
dotnet cake ./build/build.cake
|
dotnet cake ./build/build.cake "${CAKE_ARGUMENTS[@]}"
|
@ -18,7 +18,7 @@ namespace osu.Game.Rulesets.Mania.Edit.Blueprints
|
|||||||
public Vector2 ScreenSpaceDragPosition { get; private set; }
|
public Vector2 ScreenSpaceDragPosition { get; private set; }
|
||||||
public Vector2 DragPosition { get; private set; }
|
public Vector2 DragPosition { get; private set; }
|
||||||
|
|
||||||
protected new DrawableManiaHitObject HitObject => (DrawableManiaHitObject)base.HitObject;
|
public new DrawableManiaHitObject HitObject => (DrawableManiaHitObject)base.HitObject;
|
||||||
|
|
||||||
protected IClock EditorClock { get; private set; }
|
protected IClock EditorClock { get; private set; }
|
||||||
|
|
||||||
|
@ -3,9 +3,7 @@
|
|||||||
|
|
||||||
using System.Linq;
|
using System.Linq;
|
||||||
using osu.Framework.Allocation;
|
using osu.Framework.Allocation;
|
||||||
using osu.Framework.Input.Events;
|
|
||||||
using osu.Framework.Timing;
|
using osu.Framework.Timing;
|
||||||
using osu.Game.Rulesets.Edit;
|
|
||||||
using osu.Game.Rulesets.Mania.Edit.Blueprints;
|
using osu.Game.Rulesets.Mania.Edit.Blueprints;
|
||||||
using osu.Game.Rulesets.Mania.Objects;
|
using osu.Game.Rulesets.Mania.Objects;
|
||||||
using osu.Game.Rulesets.UI;
|
using osu.Game.Rulesets.UI;
|
||||||
@ -31,13 +29,16 @@ namespace osu.Game.Rulesets.Mania.Edit
|
|||||||
editorClock = clock;
|
editorClock = clock;
|
||||||
}
|
}
|
||||||
|
|
||||||
public override void HandleDrag(SelectionBlueprint blueprint, DragEvent dragEvent)
|
public override void HandleMovement(MoveSelectionEvent moveEvent)
|
||||||
{
|
{
|
||||||
adjustOrigins((ManiaSelectionBlueprint)blueprint);
|
var maniaBlueprint = (ManiaSelectionBlueprint)moveEvent.Blueprint;
|
||||||
performDragMovement(dragEvent);
|
int lastColumn = maniaBlueprint.HitObject.HitObject.Column;
|
||||||
performColumnMovement(dragEvent);
|
|
||||||
|
|
||||||
base.HandleDrag(blueprint, dragEvent);
|
adjustOrigins(maniaBlueprint);
|
||||||
|
performDragMovement(moveEvent);
|
||||||
|
performColumnMovement(lastColumn, moveEvent);
|
||||||
|
|
||||||
|
base.HandleMovement(moveEvent);
|
||||||
}
|
}
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
@ -62,7 +63,7 @@ namespace osu.Game.Rulesets.Mania.Edit
|
|||||||
b.HitObject.Y += movementDelta;
|
b.HitObject.Y += movementDelta;
|
||||||
}
|
}
|
||||||
|
|
||||||
private void performDragMovement(DragEvent dragEvent)
|
private void performDragMovement(MoveSelectionEvent moveEvent)
|
||||||
{
|
{
|
||||||
foreach (var b in SelectedBlueprints)
|
foreach (var b in SelectedBlueprints)
|
||||||
{
|
{
|
||||||
@ -72,7 +73,7 @@ namespace osu.Game.Rulesets.Mania.Edit
|
|||||||
|
|
||||||
// Using the hitobject position is required since AdjustPosition can be invoked multiple times per frame
|
// Using the hitobject position is required since AdjustPosition can be invoked multiple times per frame
|
||||||
// without the position having been updated by the parenting ScrollingHitObjectContainer
|
// without the position having been updated by the parenting ScrollingHitObjectContainer
|
||||||
hitObject.Y += dragEvent.Delta.Y;
|
hitObject.Y += moveEvent.InstantDelta.Y;
|
||||||
|
|
||||||
float targetPosition;
|
float targetPosition;
|
||||||
|
|
||||||
@ -94,14 +95,13 @@ namespace osu.Game.Rulesets.Mania.Edit
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
private void performColumnMovement(DragEvent dragEvent)
|
private void performColumnMovement(int lastColumn, MoveSelectionEvent moveEvent)
|
||||||
{
|
{
|
||||||
var lastColumn = composer.ColumnAt(dragEvent.ScreenSpaceLastMousePosition);
|
var currentColumn = composer.ColumnAt(moveEvent.ScreenSpacePosition);
|
||||||
var currentColumn = composer.ColumnAt(dragEvent.ScreenSpaceMousePosition);
|
if (currentColumn == null)
|
||||||
if (lastColumn == null || currentColumn == null)
|
|
||||||
return;
|
return;
|
||||||
|
|
||||||
int columnDelta = currentColumn.Index - lastColumn.Index;
|
int columnDelta = currentColumn.Index - lastColumn;
|
||||||
if (columnDelta == 0)
|
if (columnDelta == 0)
|
||||||
return;
|
return;
|
||||||
|
|
||||||
|
@ -2,8 +2,6 @@
|
|||||||
// See the LICENCE file in the repository root for full licence text.
|
// See the LICENCE file in the repository root for full licence text.
|
||||||
|
|
||||||
using System.Linq;
|
using System.Linq;
|
||||||
using osu.Framework.Input.Events;
|
|
||||||
using osu.Game.Rulesets.Edit;
|
|
||||||
using osu.Game.Rulesets.Osu.Objects;
|
using osu.Game.Rulesets.Osu.Objects;
|
||||||
using osu.Game.Screens.Edit.Compose.Components;
|
using osu.Game.Screens.Edit.Compose.Components;
|
||||||
|
|
||||||
@ -11,7 +9,7 @@ namespace osu.Game.Rulesets.Osu.Edit
|
|||||||
{
|
{
|
||||||
public class OsuSelectionHandler : SelectionHandler
|
public class OsuSelectionHandler : SelectionHandler
|
||||||
{
|
{
|
||||||
public override void HandleDrag(SelectionBlueprint blueprint, DragEvent dragEvent)
|
public override void HandleMovement(MoveSelectionEvent moveEvent)
|
||||||
{
|
{
|
||||||
foreach (var h in SelectedHitObjects.OfType<OsuHitObject>())
|
foreach (var h in SelectedHitObjects.OfType<OsuHitObject>())
|
||||||
{
|
{
|
||||||
@ -21,10 +19,10 @@ namespace osu.Game.Rulesets.Osu.Edit
|
|||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
h.Position += dragEvent.Delta;
|
h.Position += moveEvent.InstantDelta;
|
||||||
}
|
}
|
||||||
|
|
||||||
base.HandleDrag(blueprint, dragEvent);
|
base.HandleMovement(moveEvent);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -510,9 +510,9 @@ namespace osu.Game.Tests.Beatmaps.IO
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
public static async Task<BeatmapSetInfo> LoadOszIntoOsu(OsuGameBase osu, string path = null)
|
public static async Task<BeatmapSetInfo> LoadOszIntoOsu(OsuGameBase osu, string path = null, bool virtualTrack = false)
|
||||||
{
|
{
|
||||||
var temp = path ?? TestResources.GetTestBeatmapForImport();
|
var temp = path ?? TestResources.GetTestBeatmapForImport(virtualTrack);
|
||||||
|
|
||||||
var manager = osu.Dependencies.Get<BeatmapManager>();
|
var manager = osu.Dependencies.Get<BeatmapManager>();
|
||||||
|
|
||||||
|
@ -11,13 +11,13 @@ namespace osu.Game.Tests.Resources
|
|||||||
{
|
{
|
||||||
public static Stream OpenResource(string name) => new DllResourceStore("osu.Game.Tests.dll").GetStream($"Resources/{name}");
|
public static Stream OpenResource(string name) => new DllResourceStore("osu.Game.Tests.dll").GetStream($"Resources/{name}");
|
||||||
|
|
||||||
public static Stream GetTestBeatmapStream() => new DllResourceStore("osu.Game.Resources.dll").GetStream("Beatmaps/241526 Soleily - Renatus.osz");
|
public static Stream GetTestBeatmapStream(bool virtualTrack = false) => new DllResourceStore("osu.Game.Resources.dll").GetStream($"Beatmaps/241526 Soleily - Renatus{(virtualTrack ? "_virtual" : "")}.osz");
|
||||||
|
|
||||||
public static string GetTestBeatmapForImport()
|
public static string GetTestBeatmapForImport(bool virtualTrack = false)
|
||||||
{
|
{
|
||||||
var temp = Path.GetTempFileName() + ".osz";
|
var temp = Path.GetTempFileName() + ".osz";
|
||||||
|
|
||||||
using (var stream = GetTestBeatmapStream())
|
using (var stream = GetTestBeatmapStream(virtualTrack))
|
||||||
using (var newFile = File.Create(temp))
|
using (var newFile = File.Create(temp))
|
||||||
stream.CopyTo(newFile);
|
stream.CopyTo(newFile);
|
||||||
|
|
||||||
|
@ -5,12 +5,15 @@ using System;
|
|||||||
using System.Linq;
|
using System.Linq;
|
||||||
using NUnit.Framework;
|
using NUnit.Framework;
|
||||||
using osu.Framework.Allocation;
|
using osu.Framework.Allocation;
|
||||||
|
using osu.Framework.Audio.Track;
|
||||||
|
using osu.Framework.Bindables;
|
||||||
using osu.Framework.Graphics;
|
using osu.Framework.Graphics;
|
||||||
using osu.Framework.Graphics.Containers;
|
using osu.Framework.Graphics.Containers;
|
||||||
using osu.Framework.Graphics.Shapes;
|
using osu.Framework.Graphics.Shapes;
|
||||||
using osu.Framework.Platform;
|
using osu.Framework.Platform;
|
||||||
using osu.Framework.Screens;
|
using osu.Framework.Screens;
|
||||||
using osu.Framework.Testing;
|
using osu.Framework.Testing;
|
||||||
|
using osu.Game.Beatmaps;
|
||||||
using osu.Game.Configuration;
|
using osu.Game.Configuration;
|
||||||
using osu.Game.Graphics.UserInterface;
|
using osu.Game.Graphics.UserInterface;
|
||||||
using osu.Game.Online.API;
|
using osu.Game.Online.API;
|
||||||
@ -18,7 +21,9 @@ using osu.Game.Overlays;
|
|||||||
using osu.Game.Overlays.Mods;
|
using osu.Game.Overlays.Mods;
|
||||||
using osu.Game.Screens;
|
using osu.Game.Screens;
|
||||||
using osu.Game.Screens.Menu;
|
using osu.Game.Screens.Menu;
|
||||||
|
using osu.Game.Screens.Play;
|
||||||
using osu.Game.Screens.Select;
|
using osu.Game.Screens.Select;
|
||||||
|
using osu.Game.Tests.Beatmaps.IO;
|
||||||
using osuTK;
|
using osuTK;
|
||||||
using osuTK.Graphics;
|
using osuTK.Graphics;
|
||||||
using osuTK.Input;
|
using osuTK.Input;
|
||||||
@ -31,11 +36,11 @@ namespace osu.Game.Tests.Visual.Menus
|
|||||||
private const float click_padding = 25;
|
private const float click_padding = 25;
|
||||||
|
|
||||||
private GameHost host;
|
private GameHost host;
|
||||||
private TestOsuGame osuGame;
|
private TestOsuGame game;
|
||||||
|
|
||||||
private Vector2 backButtonPosition => osuGame.ToScreenSpace(new Vector2(click_padding, osuGame.LayoutRectangle.Bottom - click_padding));
|
private Vector2 backButtonPosition => game.ToScreenSpace(new Vector2(click_padding, game.LayoutRectangle.Bottom - click_padding));
|
||||||
|
|
||||||
private Vector2 optionsButtonPosition => osuGame.ToScreenSpace(new Vector2(click_padding, click_padding));
|
private Vector2 optionsButtonPosition => game.ToScreenSpace(new Vector2(click_padding, click_padding));
|
||||||
|
|
||||||
[BackgroundDependencyLoader]
|
[BackgroundDependencyLoader]
|
||||||
private void load(GameHost host)
|
private void load(GameHost host)
|
||||||
@ -54,23 +59,23 @@ namespace osu.Game.Tests.Visual.Menus
|
|||||||
{
|
{
|
||||||
AddStep("Create new game instance", () =>
|
AddStep("Create new game instance", () =>
|
||||||
{
|
{
|
||||||
if (osuGame != null)
|
if (game != null)
|
||||||
{
|
{
|
||||||
Remove(osuGame);
|
Remove(game);
|
||||||
osuGame.Dispose();
|
game.Dispose();
|
||||||
}
|
}
|
||||||
|
|
||||||
osuGame = new TestOsuGame(LocalStorage, API);
|
game = new TestOsuGame(LocalStorage, API);
|
||||||
osuGame.SetHost(host);
|
game.SetHost(host);
|
||||||
|
|
||||||
// todo: this can be removed once we can run audio trakcs without a device present
|
// todo: this can be removed once we can run audio trakcs without a device present
|
||||||
// see https://github.com/ppy/osu/issues/1302
|
// see https://github.com/ppy/osu/issues/1302
|
||||||
osuGame.LocalConfig.Set(OsuSetting.IntroSequence, IntroSequence.Circles);
|
game.LocalConfig.Set(OsuSetting.IntroSequence, IntroSequence.Circles);
|
||||||
|
|
||||||
Add(osuGame);
|
Add(game);
|
||||||
});
|
});
|
||||||
AddUntilStep("Wait for load", () => osuGame.IsLoaded);
|
AddUntilStep("Wait for load", () => game.IsLoaded);
|
||||||
AddUntilStep("Wait for intro", () => osuGame.ScreenStack.CurrentScreen is IntroScreen);
|
AddUntilStep("Wait for intro", () => game.ScreenStack.CurrentScreen is IntroScreen);
|
||||||
confirmAtMainMenu();
|
confirmAtMainMenu();
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -82,11 +87,43 @@ namespace osu.Game.Tests.Visual.Menus
|
|||||||
pushAndConfirm(() => songSelect = new TestSongSelect());
|
pushAndConfirm(() => songSelect = new TestSongSelect());
|
||||||
AddStep("Show mods overlay", () => songSelect.ModSelectOverlay.Show());
|
AddStep("Show mods overlay", () => songSelect.ModSelectOverlay.Show());
|
||||||
AddAssert("Overlay was shown", () => songSelect.ModSelectOverlay.State.Value == Visibility.Visible);
|
AddAssert("Overlay was shown", () => songSelect.ModSelectOverlay.State.Value == Visibility.Visible);
|
||||||
AddStep("Press escape", () => pressAndRelease(Key.Escape));
|
pushEscape();
|
||||||
AddAssert("Overlay was hidden", () => songSelect.ModSelectOverlay.State.Value == Visibility.Hidden);
|
AddAssert("Overlay was hidden", () => songSelect.ModSelectOverlay.State.Value == Visibility.Hidden);
|
||||||
exitViaEscapeAndConfirm();
|
exitViaEscapeAndConfirm();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
[TestCase(true)]
|
||||||
|
[TestCase(false)]
|
||||||
|
public void TestSongContinuesAfterExitPlayer(bool withUserPause)
|
||||||
|
{
|
||||||
|
Player player = null;
|
||||||
|
|
||||||
|
WorkingBeatmap beatmap() => game.Beatmap.Value;
|
||||||
|
Track track() => beatmap().Track;
|
||||||
|
|
||||||
|
pushAndConfirm(() => new TestSongSelect());
|
||||||
|
|
||||||
|
AddStep("import beatmap", () => ImportBeatmapTest.LoadOszIntoOsu(game, virtualTrack: true).Wait());
|
||||||
|
|
||||||
|
AddUntilStep("wait for selected", () => !game.Beatmap.IsDefault);
|
||||||
|
|
||||||
|
if (withUserPause)
|
||||||
|
AddStep("pause", () => game.Dependencies.Get<MusicController>().Stop());
|
||||||
|
|
||||||
|
AddStep("press enter", () => pressAndRelease(Key.Enter));
|
||||||
|
|
||||||
|
AddUntilStep("wait for player", () => (player = game.ScreenStack.CurrentScreen as Player) != null);
|
||||||
|
AddUntilStep("wait for fail", () => player.HasFailed);
|
||||||
|
|
||||||
|
AddUntilStep("wait for track stop", () => !track().IsRunning);
|
||||||
|
AddAssert("Ensure time before preview point", () => track().CurrentTime < beatmap().Metadata.PreviewTime);
|
||||||
|
|
||||||
|
pushEscape();
|
||||||
|
|
||||||
|
AddUntilStep("wait for track playing", () => track().IsRunning);
|
||||||
|
AddAssert("Ensure time wasn't reset to preview point", () => track().CurrentTime < beatmap().Metadata.PreviewTime);
|
||||||
|
}
|
||||||
|
|
||||||
[Test]
|
[Test]
|
||||||
public void TestExitSongSelectWithClick()
|
public void TestExitSongSelectWithClick()
|
||||||
{
|
{
|
||||||
@ -98,7 +135,7 @@ namespace osu.Game.Tests.Visual.Menus
|
|||||||
AddStep("Move mouse to backButton", () => InputManager.MoveMouseTo(backButtonPosition));
|
AddStep("Move mouse to backButton", () => InputManager.MoveMouseTo(backButtonPosition));
|
||||||
|
|
||||||
// BackButton handles hover using its child button, so this checks whether or not any of BackButton's children are hovered.
|
// BackButton handles hover using its child button, so this checks whether or not any of BackButton's children are hovered.
|
||||||
AddUntilStep("Back button is hovered", () => InputManager.HoveredDrawables.Any(d => d.Parent == osuGame.BackButton));
|
AddUntilStep("Back button is hovered", () => InputManager.HoveredDrawables.Any(d => d.Parent == game.BackButton));
|
||||||
|
|
||||||
AddStep("Click back button", () => InputManager.Click(MouseButton.Left));
|
AddStep("Click back button", () => InputManager.Click(MouseButton.Left));
|
||||||
AddUntilStep("Overlay was hidden", () => songSelect.ModSelectOverlay.State.Value == Visibility.Hidden);
|
AddUntilStep("Overlay was hidden", () => songSelect.ModSelectOverlay.State.Value == Visibility.Hidden);
|
||||||
@ -122,25 +159,28 @@ namespace osu.Game.Tests.Visual.Menus
|
|||||||
[Test]
|
[Test]
|
||||||
public void TestOpenOptionsAndExitWithEscape()
|
public void TestOpenOptionsAndExitWithEscape()
|
||||||
{
|
{
|
||||||
AddUntilStep("Wait for options to load", () => osuGame.Settings.IsLoaded);
|
AddUntilStep("Wait for options to load", () => game.Settings.IsLoaded);
|
||||||
AddStep("Enter menu", () => pressAndRelease(Key.Enter));
|
AddStep("Enter menu", () => pressAndRelease(Key.Enter));
|
||||||
AddStep("Move mouse to options overlay", () => InputManager.MoveMouseTo(optionsButtonPosition));
|
AddStep("Move mouse to options overlay", () => InputManager.MoveMouseTo(optionsButtonPosition));
|
||||||
AddStep("Click options overlay", () => InputManager.Click(MouseButton.Left));
|
AddStep("Click options overlay", () => InputManager.Click(MouseButton.Left));
|
||||||
AddAssert("Options overlay was opened", () => osuGame.Settings.State.Value == Visibility.Visible);
|
AddAssert("Options overlay was opened", () => game.Settings.State.Value == Visibility.Visible);
|
||||||
AddStep("Hide options overlay using escape", () => pressAndRelease(Key.Escape));
|
AddStep("Hide options overlay using escape", () => pressAndRelease(Key.Escape));
|
||||||
AddAssert("Options overlay was closed", () => osuGame.Settings.State.Value == Visibility.Hidden);
|
AddAssert("Options overlay was closed", () => game.Settings.State.Value == Visibility.Hidden);
|
||||||
}
|
}
|
||||||
|
|
||||||
private void pushAndConfirm(Func<Screen> newScreen)
|
private void pushAndConfirm(Func<Screen> newScreen)
|
||||||
{
|
{
|
||||||
Screen screen = null;
|
Screen screen = null;
|
||||||
AddStep("Push new screen", () => osuGame.ScreenStack.Push(screen = newScreen()));
|
AddStep("Push new screen", () => game.ScreenStack.Push(screen = newScreen()));
|
||||||
AddUntilStep("Wait for new screen", () => osuGame.ScreenStack.CurrentScreen == screen && screen.IsLoaded);
|
AddUntilStep("Wait for new screen", () => game.ScreenStack.CurrentScreen == screen && screen.IsLoaded);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
private void pushEscape() =>
|
||||||
|
AddStep("Press escape", () => pressAndRelease(Key.Escape));
|
||||||
|
|
||||||
private void exitViaEscapeAndConfirm()
|
private void exitViaEscapeAndConfirm()
|
||||||
{
|
{
|
||||||
AddStep("Press escape", () => pressAndRelease(Key.Escape));
|
pushEscape();
|
||||||
confirmAtMainMenu();
|
confirmAtMainMenu();
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -151,7 +191,7 @@ namespace osu.Game.Tests.Visual.Menus
|
|||||||
confirmAtMainMenu();
|
confirmAtMainMenu();
|
||||||
}
|
}
|
||||||
|
|
||||||
private void confirmAtMainMenu() => AddUntilStep("Wait for main menu", () => osuGame.ScreenStack.CurrentScreen is MainMenu menu && menu.IsLoaded);
|
private void confirmAtMainMenu() => AddUntilStep("Wait for main menu", () => game.ScreenStack.CurrentScreen is MainMenu menu && menu.IsLoaded);
|
||||||
|
|
||||||
private void pressAndRelease(Key key)
|
private void pressAndRelease(Key key)
|
||||||
{
|
{
|
||||||
@ -169,6 +209,8 @@ namespace osu.Game.Tests.Visual.Menus
|
|||||||
|
|
||||||
public new OsuConfigManager LocalConfig => base.LocalConfig;
|
public new OsuConfigManager LocalConfig => base.LocalConfig;
|
||||||
|
|
||||||
|
public new Bindable<WorkingBeatmap> Beatmap => base.Beatmap;
|
||||||
|
|
||||||
protected override Loader CreateLoader() => new TestLoader();
|
protected override Loader CreateLoader() => new TestLoader();
|
||||||
|
|
||||||
public TestOsuGame(Storage storage, IAPIProvider api)
|
public TestOsuGame(Storage storage, IAPIProvider api)
|
||||||
|
@ -1,12 +1,9 @@
|
|||||||
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
||||||
// See the LICENCE file in the repository root for full licence text.
|
// See the LICENCE file in the repository root for full licence text.
|
||||||
|
|
||||||
using System.Collections.Generic;
|
|
||||||
using osu.Game.Online.API.Requests.Responses;
|
|
||||||
|
|
||||||
namespace osu.Game.Online.API.Requests
|
namespace osu.Game.Online.API.Requests
|
||||||
{
|
{
|
||||||
public class GetUsersRequest : APIRequest<List<APIUser>>
|
public class GetUsersRequest : APIRequest<GetUsersResponse>
|
||||||
{
|
{
|
||||||
protected override string Target => @"rankings/osu/performance";
|
protected override string Target => @"rankings/osu/performance";
|
||||||
}
|
}
|
||||||
|
15
osu.Game/Online/API/Requests/GetUsersResponse.cs
Normal file
15
osu.Game/Online/API/Requests/GetUsersResponse.cs
Normal file
@ -0,0 +1,15 @@
|
|||||||
|
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
||||||
|
// See the LICENCE file in the repository root for full licence text.
|
||||||
|
|
||||||
|
using System.Collections.Generic;
|
||||||
|
using Newtonsoft.Json;
|
||||||
|
using osu.Game.Online.API.Requests.Responses;
|
||||||
|
|
||||||
|
namespace osu.Game.Online.API.Requests
|
||||||
|
{
|
||||||
|
public class GetUsersResponse : ResponseWithCursor
|
||||||
|
{
|
||||||
|
[JsonProperty("ranking")]
|
||||||
|
public List<APIUser> Users;
|
||||||
|
}
|
||||||
|
}
|
16
osu.Game/Online/API/Requests/ResponseWithCursor.cs
Normal file
16
osu.Game/Online/API/Requests/ResponseWithCursor.cs
Normal file
@ -0,0 +1,16 @@
|
|||||||
|
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
||||||
|
// See the LICENCE file in the repository root for full licence text.
|
||||||
|
|
||||||
|
using Newtonsoft.Json;
|
||||||
|
|
||||||
|
namespace osu.Game.Online.API.Requests
|
||||||
|
{
|
||||||
|
public abstract class ResponseWithCursor
|
||||||
|
{
|
||||||
|
/// <summary>
|
||||||
|
/// A collection of parameters which should be passed to the search endpoint to fetch the next page.
|
||||||
|
/// </summary>
|
||||||
|
[JsonProperty("cursor")]
|
||||||
|
public dynamic CursorJson;
|
||||||
|
}
|
||||||
|
}
|
@ -2,19 +2,12 @@
|
|||||||
// See the LICENCE file in the repository root for full licence text.
|
// See the LICENCE file in the repository root for full licence text.
|
||||||
|
|
||||||
using System.Collections.Generic;
|
using System.Collections.Generic;
|
||||||
using Newtonsoft.Json;
|
|
||||||
using osu.Game.Online.API.Requests.Responses;
|
using osu.Game.Online.API.Requests.Responses;
|
||||||
|
|
||||||
namespace osu.Game.Online.API.Requests
|
namespace osu.Game.Online.API.Requests
|
||||||
{
|
{
|
||||||
public class SearchBeatmapSetsResponse
|
public class SearchBeatmapSetsResponse : ResponseWithCursor
|
||||||
{
|
{
|
||||||
public IEnumerable<APIBeatmapSet> BeatmapSets;
|
public IEnumerable<APIBeatmapSet> BeatmapSets;
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// A collection of parameters which should be passed to the search endpoint to fetch the next page.
|
|
||||||
/// </summary>
|
|
||||||
[JsonProperty("cursor")]
|
|
||||||
public dynamic CursorJson;
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -98,20 +98,13 @@ namespace osu.Game.Overlays
|
|||||||
/// <summary>
|
/// <summary>
|
||||||
/// Start playing the current track (if not already playing).
|
/// Start playing the current track (if not already playing).
|
||||||
/// </summary>
|
/// </summary>
|
||||||
public void Play()
|
|
||||||
{
|
|
||||||
if (!IsPlaying)
|
|
||||||
TogglePause();
|
|
||||||
}
|
|
||||||
|
|
||||||
/// <summary>
|
|
||||||
/// Toggle pause / play.
|
|
||||||
/// </summary>
|
|
||||||
/// <returns>Whether the operation was successful.</returns>
|
/// <returns>Whether the operation was successful.</returns>
|
||||||
public bool TogglePause()
|
public bool Play(bool restart = false)
|
||||||
{
|
{
|
||||||
var track = current?.Track;
|
var track = current?.Track;
|
||||||
|
|
||||||
|
IsUserPaused = false;
|
||||||
|
|
||||||
if (track == null)
|
if (track == null)
|
||||||
{
|
{
|
||||||
if (beatmap.Disabled)
|
if (beatmap.Disabled)
|
||||||
@ -121,16 +114,38 @@ namespace osu.Game.Overlays
|
|||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (track.IsRunning)
|
if (restart)
|
||||||
{
|
track.Restart();
|
||||||
IsUserPaused = true;
|
else if (!IsPlaying)
|
||||||
track.Stop();
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
|
||||||
track.Start();
|
track.Start();
|
||||||
IsUserPaused = false;
|
|
||||||
}
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// Stop playing the current track and pause at the current position.
|
||||||
|
/// </summary>
|
||||||
|
public void Stop()
|
||||||
|
{
|
||||||
|
var track = current?.Track;
|
||||||
|
|
||||||
|
IsUserPaused = true;
|
||||||
|
if (track?.IsRunning == true)
|
||||||
|
track.Stop();
|
||||||
|
}
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// Toggle pause / play.
|
||||||
|
/// </summary>
|
||||||
|
/// <returns>Whether the operation was successful.</returns>
|
||||||
|
public bool TogglePause()
|
||||||
|
{
|
||||||
|
var track = current?.Track;
|
||||||
|
|
||||||
|
if (track?.IsRunning == true)
|
||||||
|
Stop();
|
||||||
|
else
|
||||||
|
Play();
|
||||||
|
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
@ -118,7 +118,7 @@ namespace osu.Game.Overlays
|
|||||||
|
|
||||||
default:
|
default:
|
||||||
var userRequest = new GetUsersRequest(); // TODO filter arguments!
|
var userRequest = new GetUsersRequest(); // TODO filter arguments!
|
||||||
userRequest.Success += response => updateUsers(response.Select(r => r.User));
|
userRequest.Success += res => updateUsers(res.Users.Select(r => r.User));
|
||||||
API.Queue(getUsersRequest = userRequest);
|
API.Queue(getUsersRequest = userRequest);
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
|
@ -45,6 +45,11 @@ namespace osu.Game.Rulesets.Edit
|
|||||||
/// </summary>
|
/// </summary>
|
||||||
public readonly DrawableHitObject HitObject;
|
public readonly DrawableHitObject HitObject;
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// The screen-space position of <see cref="HitObject"/> prior to handling a movement event.
|
||||||
|
/// </summary>
|
||||||
|
internal Vector2 ScreenSpaceMovementStartPosition { get; private set; }
|
||||||
|
|
||||||
protected override bool ShouldBeAlive => (HitObject.IsAlive && HitObject.IsPresent) || State == SelectionState.Selected;
|
protected override bool ShouldBeAlive => (HitObject.IsAlive && HitObject.IsPresent) || State == SelectionState.Selected;
|
||||||
public override bool HandlePositionalInput => ShouldBeAlive;
|
public override bool HandlePositionalInput => ShouldBeAlive;
|
||||||
public override bool RemoveWhenNotAlive => false;
|
public override bool RemoveWhenNotAlive => false;
|
||||||
@ -131,7 +136,11 @@ namespace osu.Game.Rulesets.Edit
|
|||||||
return base.OnClick(e);
|
return base.OnClick(e);
|
||||||
}
|
}
|
||||||
|
|
||||||
protected override bool OnDragStart(DragStartEvent e) => true;
|
protected override bool OnDragStart(DragStartEvent e)
|
||||||
|
{
|
||||||
|
ScreenSpaceMovementStartPosition = HitObject.ToScreenSpace(HitObject.OriginPosition);
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
protected override bool OnDrag(DragEvent e)
|
protected override bool OnDrag(DragEvent e)
|
||||||
{
|
{
|
||||||
|
@ -216,7 +216,12 @@ namespace osu.Game.Screens.Edit.Compose.Components
|
|||||||
|
|
||||||
private void onSelectionRequested(SelectionBlueprint blueprint, InputState state) => selectionHandler.HandleSelectionRequested(blueprint, state);
|
private void onSelectionRequested(SelectionBlueprint blueprint, InputState state) => selectionHandler.HandleSelectionRequested(blueprint, state);
|
||||||
|
|
||||||
private void onDragRequested(SelectionBlueprint blueprint, DragEvent dragEvent) => selectionHandler.HandleDrag(blueprint, dragEvent);
|
private void onDragRequested(SelectionBlueprint blueprint, DragEvent dragEvent)
|
||||||
|
{
|
||||||
|
var movePosition = blueprint.ScreenSpaceMovementStartPosition + dragEvent.ScreenSpaceMousePosition - dragEvent.ScreenSpaceMouseDownPosition;
|
||||||
|
|
||||||
|
selectionHandler.HandleMovement(new MoveSelectionEvent(blueprint, blueprint.ScreenSpaceMovementStartPosition, movePosition));
|
||||||
|
}
|
||||||
|
|
||||||
protected override void Dispose(bool isDisposing)
|
protected override void Dispose(bool isDisposing)
|
||||||
{
|
{
|
||||||
|
@ -0,0 +1,46 @@
|
|||||||
|
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
||||||
|
// See the LICENCE file in the repository root for full licence text.
|
||||||
|
|
||||||
|
using osu.Game.Rulesets.Edit;
|
||||||
|
using osuTK;
|
||||||
|
|
||||||
|
namespace osu.Game.Screens.Edit.Compose.Components
|
||||||
|
{
|
||||||
|
/// <summary>
|
||||||
|
/// An event which occurs when a <see cref="SelectionBlueprint"/> is moved.
|
||||||
|
/// </summary>
|
||||||
|
public class MoveSelectionEvent
|
||||||
|
{
|
||||||
|
/// <summary>
|
||||||
|
/// The <see cref="SelectionBlueprint"/> that triggered this <see cref="MoveSelectionEvent"/>.
|
||||||
|
/// </summary>
|
||||||
|
public readonly SelectionBlueprint Blueprint;
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// The starting screen-space position of the hitobject.
|
||||||
|
/// </summary>
|
||||||
|
public readonly Vector2 ScreenSpaceStartPosition;
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// The expected screen-space position of the hitobject at the current cursor position.
|
||||||
|
/// </summary>
|
||||||
|
public readonly Vector2 ScreenSpacePosition;
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// The distance between <see cref="ScreenSpacePosition"/> and the hitobject's current position, in the coordinate-space of the hitobject's parent.
|
||||||
|
/// </summary>
|
||||||
|
/// <remarks>
|
||||||
|
/// This does not use <see cref="ScreenSpaceStartPosition"/> and does not represent the cumulative movement distance.
|
||||||
|
/// </remarks>
|
||||||
|
public readonly Vector2 InstantDelta;
|
||||||
|
|
||||||
|
public MoveSelectionEvent(SelectionBlueprint blueprint, Vector2 screenSpaceStartPosition, Vector2 screenSpacePosition)
|
||||||
|
{
|
||||||
|
Blueprint = blueprint;
|
||||||
|
ScreenSpaceStartPosition = screenSpaceStartPosition;
|
||||||
|
ScreenSpacePosition = screenSpacePosition;
|
||||||
|
|
||||||
|
InstantDelta = Blueprint.HitObject.Parent.ToLocalSpace(ScreenSpacePosition) - Blueprint.HitObject.Position;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
@ -65,11 +65,10 @@ namespace osu.Game.Screens.Edit.Compose.Components
|
|||||||
#region User Input Handling
|
#region User Input Handling
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Handles the selected <see cref="DrawableHitObject"/>s being dragged.
|
/// Handles the selected <see cref="DrawableHitObject"/>s being moved.
|
||||||
/// </summary>
|
/// </summary>
|
||||||
/// <param name="blueprint">The <see cref="SelectionBlueprint"/> that received the drag event.</param>
|
/// <param name="moveEvent">The move event.</param>
|
||||||
/// <param name="dragEvent">The drag event.</param>
|
public virtual void HandleMovement(MoveSelectionEvent moveEvent)
|
||||||
public virtual void HandleDrag(SelectionBlueprint blueprint, DragEvent dragEvent)
|
|
||||||
{
|
{
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -486,7 +486,9 @@ namespace osu.Game.Screens.Select
|
|||||||
if (Beatmap != null && !Beatmap.Value.BeatmapSetInfo.DeletePending)
|
if (Beatmap != null && !Beatmap.Value.BeatmapSetInfo.DeletePending)
|
||||||
{
|
{
|
||||||
UpdateBeatmap(Beatmap.Value);
|
UpdateBeatmap(Beatmap.Value);
|
||||||
ensurePlayingSelected();
|
|
||||||
|
// restart playback on returning to song select, regardless.
|
||||||
|
music?.Play();
|
||||||
}
|
}
|
||||||
|
|
||||||
base.OnResuming(last);
|
base.OnResuming(last);
|
||||||
@ -592,7 +594,7 @@ namespace osu.Game.Screens.Select
|
|||||||
track.RestartPoint = Beatmap.Value.Metadata.PreviewTime;
|
track.RestartPoint = Beatmap.Value.Metadata.PreviewTime;
|
||||||
|
|
||||||
if (!track.IsRunning && (music?.IsUserPaused != true || isNewTrack))
|
if (!track.IsRunning && (music?.IsUserPaused != true || isNewTrack))
|
||||||
track.Restart();
|
music?.Play(true);
|
||||||
|
|
||||||
lastTrack.SetTarget(track);
|
lastTrack.SetTarget(track);
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user