h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 12:33:01 +08:00
Code Issues Releases Wiki Activity

Merge pull request #11735 from peppy/decrease-global-track-volume

Browse Source 
Decrease the game-wide track playback volume to give samples some head-room
This commit is contained in:
Dan Balasescu 2021-02-12 00:19:32 +09:00 committed by GitHub
commit 0040f14132
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
osu.Game/OsuGameBase.cs
View File

@ -155,6 +155,8 @@ namespace osu.Game
protected override UserInputManager CreateUserInputManager() => new OsuUserInputManager(); protected override UserInputManager CreateUserInputManager() => new OsuUserInputManager();
private readonly BindableNumber<double> globalTrackVolumeAdjust = new BindableNumber<double>(0.5f);
[BackgroundDependencyLoader] [BackgroundDependencyLoader]
private void load() private void load()
{ {
@ -278,9 +280,10 @@ namespace osu.Game
RegisterImportHandler(ScoreManager); RegisterImportHandler(ScoreManager);
RegisterImportHandler(SkinManager); RegisterImportHandler(SkinManager);
// tracks play so loud our samples can't keep up. // drop track volume game-wide to leave some head-room for UI effects / samples.
// this adds a global reduction of track volume for the time being. // this means that for the time being, gameplay sample playback is louder relative to the audio track, compared to stable.
Audio.Tracks.AddAdjustment(AdjustableProperty.Volume, new BindableDouble(0.8)); // we may want to revisit this if users notice or complain about the difference (consider this a bit of a trial).
Audio.Tracks.AddAdjustment(AdjustableProperty.Volume, globalTrackVolumeAdjust);
Beatmap = new NonNullableBindable<WorkingBeatmap>(defaultBeatmap); Beatmap = new NonNullableBindable<WorkingBeatmap>(defaultBeatmap);