osu-lazer/osu.Game/Rulesets/Objects/Legacy/Mania/ConvertHit.cs

// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text.

using osu.Game.Rulesets.Objects.Types;

namespace osu.Game.Rulesets.Objects.Legacy.Mania
{
    /// <summary>
    /// Legacy osu!mania Hit-type, used for parsing Beatmaps.
    /// </summary>
    internal sealed class ConvertHit : ConvertHitObject, IHasXPosition
    {
        public float X { get; set; }
    }
}
-												Update licence header (and remove year)

											
										
										
											2019-01-24 16:43:03 +08:00
+								// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
 								// See the LICENCE file in the repository root for full licence text.
-												Normalize all the line endings

											
										
										
											2018-04-13 17:19:50 +08:00
-												Mode -> Ruleset.

											
										
										
											2017-04-18 15:05:58 +08:00
+								using osu.Game.Rulesets.Objects.Types;
-												Normalize all the line endings

											
										
										
											2018-04-13 17:19:50 +08:00
-												Mode -> Ruleset.

											
										
										
											2017-04-18 15:05:58 +08:00
+								namespace osu.Game.Rulesets.Objects.Legacy.Mania
-												Rework/rewrite beatmap parsing to parse to base hit objects, which mode-specific beatmap converters can then use.

											
										
										
											2017-03-13 18:15:25 +08:00
+								{
-												Fix failing unit test, move legacy hitobjects to Objects/Legacy/.

											
										
										
											2017-03-14 17:06:32 +08:00
+								    /// <summary>
-												A few xmldoc additions/fixes.

											
										
										
											2017-04-18 08:13:36 +08:00
+								    /// Legacy osu!mania Hit-type, used for parsing Beatmaps.
-												Fix failing unit test, move legacy hitobjects to Objects/Legacy/.

											
										
										
											2017-03-14 17:06:32 +08:00
+								    /// </summary>
-												Fix hitobjects with unknown lifetimes by enforcing non-null judgement

We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
CreateJudgement() must be implemented and return a non-null judgement.

This fixes BananaShower and JuiceStreams in osu!catch.

This also makes HitObject abstract and cleans up convert HitObject implementations.

											
										
										
											2020-02-23 12:01:30 +08:00
+								    internal sealed class ConvertHit : ConvertHitObject, IHasXPosition
-												Rework/rewrite beatmap parsing to parse to base hit objects, which mode-specific beatmap converters can then use.

											
										
										
											2017-03-13 18:15:25 +08:00
+								    {
-												Legacy mania hit objects don't have a "column", this should be determined by the beatmap converter.

											
										
										
											2017-04-18 10:13:11 +08:00
+								        public float X { get; set; }
-												Rework/rewrite beatmap parsing to parse to base hit objects, which mode-specific beatmap converters can then use.

											
										
										
											2017-03-13 18:15:25 +08:00
+								    }
 								}