osu-lazer/osu.Game/Rulesets/Judgements/IgnoreJudgement.cs

// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text.

using osu.Game.Rulesets.Scoring;

namespace osu.Game.Rulesets.Judgements
{
    public class IgnoreJudgement : Judgement
    {
        public override HitResult MaxResult => HitResult.IgnoreHit;
    }
}
-												Fix hitobjects with unknown lifetimes by enforcing non-null judgement

We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
CreateJudgement() must be implemented and return a non-null judgement.

This fixes BananaShower and JuiceStreams in osu!catch.

This also makes HitObject abstract and cleans up convert HitObject implementations.

											
										
										
											2020-02-23 12:01:30 +08:00
+								// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
-												Update licence header (and remove year)

											
										
										
											2019-01-24 16:43:03 +08:00
+								// See the LICENCE file in the repository root for full licence text.
-												Fixed taiko swell hp and scoring

											
										
										
											2018-11-29 23:05:13 +08:00
 								using osu.Game.Rulesets.Scoring;
-												Fix hitobjects with unknown lifetimes by enforcing non-null judgement

We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
CreateJudgement() must be implemented and return a non-null judgement.

This fixes BananaShower and JuiceStreams in osu!catch.

This also makes HitObject abstract and cleans up convert HitObject implementations.

											
										
										
											2020-02-23 12:01:30 +08:00
+								namespace osu.Game.Rulesets.Judgements
-												Fixed taiko swell hp and scoring

											
										
										
											2018-11-29 23:05:13 +08:00
+								{
-												Fix hitobjects with unknown lifetimes by enforcing non-null judgement

We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
CreateJudgement() must be implemented and return a non-null judgement.

This fixes BananaShower and JuiceStreams in osu!catch.

This also makes HitObject abstract and cleans up convert HitObject implementations.

											
										
										
											2020-02-23 12:01:30 +08:00
+								    public class IgnoreJudgement : Judgement
-												Fixed taiko swell hp and scoring

											
										
										
											2018-11-29 23:05:13 +08:00
+								    {
-												Fix a few missed judgements

											
										
										
											2020-09-29 14:20:47 +08:00
+								        public override HitResult MaxResult => HitResult.IgnoreHit;
-												Fixed taiko swell hp and scoring

											
										
										
											2018-11-29 23:05:13 +08:00
+								    }
 								}