From a74abd8be0f2efb352e8ee07965455f6c3c0f4a8 Mon Sep 17 00:00:00 2001 From: TRox1972 Date: Sun, 22 May 2016 18:15:01 +0200 Subject: [PATCH 1/2] [extractor/generic] fix RollingStone test and improve Brightcove embed extraction --- youtube_dl/extractor/generic.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/youtube_dl/extractor/generic.py b/youtube_dl/extractor/generic.py index bb96e7231..d2061474c 100644 --- a/youtube_dl/extractor/generic.py +++ b/youtube_dl/extractor/generic.py @@ -385,17 +385,16 @@ class GenericIE(InfoExtractor): 'skip_download': True, # m3u8 download }, }, - # ooyala video { 'url': 'http://www.rollingstone.com/music/videos/norwegian-dj-cashmere-cat-goes-spartan-on-with-me-premiere-20131219', - 'md5': '166dd577b433b4d4ebfee10b0824d8ff', + 'md5': '1cef60edeafd0800b57bf8cbb851ae72', 'info_dict': { - 'id': 'BwY2RxaTrTkslxOfcan0UCf0YqyvWysJ', + 'id': '4404576300001', 'ext': 'mp4', - 'title': '2cc213299525360.mov', # that's what we get + 'title': 'Music Video', 'duration': 238.231, }, - 'add_ie': ['Ooyala'], + 'add_ie': ['BrightcoveNew'], }, { # ooyala video embedded with http://player.ooyala.com/iframe.js @@ -1659,9 +1658,10 @@ class GenericIE(InfoExtractor): # Look for Ooyala videos mobj = (re.search(r'player\.ooyala\.com/[^"?]+[?#][^"]*?(?:embedCode|ec)=(?P[^"&]+)', webpage) or - re.search(r'OO\.Player\.create\([\'"].*?[\'"],\s*[\'"](?P.{32})[\'"]', webpage) or - re.search(r'SBN\.VideoLinkset\.ooyala\([\'"](?P.{32})[\'"]\)', webpage) or - re.search(r'data-ooyala-video-id\s*=\s*[\'"](?P.{32})[\'"]', webpage)) + re.search(r'OO\.Player\.create\([\'"].*?[\'"],\s*[\'"](?P\w{32})[\'"]', webpage) or + re.search(r'SBN\.VideoLinkset\.ooyala\([\'"](?P\w{32})[\'"]\)', webpage) or + re.search(r'data-ooyala-video-id\s*=\s*[\'"](?P\w{32})[\'"]', webpage) or + re.search(r'"ooyalaplayer-1",\s*"(?P\w{32})"', webpage)) if mobj is not None: return OoyalaIE._build_url_result(smuggle_url(mobj.group('ec'), {'domain': url})) From 9d4b1e67801a6571ebbbcc7f9bc31c0ea78ee30e Mon Sep 17 00:00:00 2001 From: TRox1972 Date: Wed, 25 May 2016 19:09:42 +0200 Subject: [PATCH 2/2] [extractor/generic] revert incorrect regex --- youtube_dl/extractor/generic.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/youtube_dl/extractor/generic.py b/youtube_dl/extractor/generic.py index d2061474c..1420853db 100644 --- a/youtube_dl/extractor/generic.py +++ b/youtube_dl/extractor/generic.py @@ -1658,10 +1658,10 @@ class GenericIE(InfoExtractor): # Look for Ooyala videos mobj = (re.search(r'player\.ooyala\.com/[^"?]+[?#][^"]*?(?:embedCode|ec)=(?P[^"&]+)', webpage) or - re.search(r'OO\.Player\.create\([\'"].*?[\'"],\s*[\'"](?P\w{32})[\'"]', webpage) or - re.search(r'SBN\.VideoLinkset\.ooyala\([\'"](?P\w{32})[\'"]\)', webpage) or - re.search(r'data-ooyala-video-id\s*=\s*[\'"](?P\w{32})[\'"]', webpage) or - re.search(r'"ooyalaplayer-1",\s*"(?P\w{32})"', webpage)) + re.search(r'OO\.Player\.create\([\'"].*?[\'"],\s*[\'"](?P.{32})[\'"]', webpage) or + re.search(r'SBN\.VideoLinkset\.ooyala\([\'"](?P.{32})[\'"]\)', webpage) or + re.search(r'data-ooyala-video-id\s*=\s*[\'"](?P.{32})[\'"]', webpage) or + re.search(r'"ooyalaplayer-1",\s*"(?P.{32})"', webpage)) if mobj is not None: return OoyalaIE._build_url_result(smuggle_url(mobj.group('ec'), {'domain': url}))