From c16ec093fc4b8e204596561a700b42134d63543c Mon Sep 17 00:00:00 2001 From: Matanya Moses Date: Wed, 19 Nov 2014 17:16:32 +0200 Subject: [PATCH] Add options to ffmpeg post processing MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit https://trac.ffmpeg.org/wiki/Encode/VP8 ffmpeg guide stats: "Important: If neither -b:v nor -crf are set, the encoder will use a low default bitrate and your result will probably look very bad. Always supply one of these options—ideally both." --- youtube_dl/postprocessor/ffmpeg.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/youtube_dl/postprocessor/ffmpeg.py b/youtube_dl/postprocessor/ffmpeg.py index f3f2743c0..9ec22cd19 100644 --- a/youtube_dl/postprocessor/ffmpeg.py +++ b/youtube_dl/postprocessor/ffmpeg.py @@ -235,9 +235,10 @@ class FFmpegExtractAudioPP(FFmpegPostProcessor): class FFmpegVideoConvertor(FFmpegPostProcessor): - def __init__(self, downloader=None,preferedformat=None): + def __init__(self, downloader=None,preferedformat=None,opts=[]): super(FFmpegVideoConvertor, self).__init__(downloader) self._preferedformat=preferedformat + self._opts = opts def run(self, information): path = information['filepath'] @@ -247,7 +248,7 @@ class FFmpegVideoConvertor(FFmpegPostProcessor): self._downloader.to_screen(u'[ffmpeg] Not converting video file %s - already is in target format %s' % (path, self._preferedformat)) return True,information self._downloader.to_screen(u'['+'ffmpeg'+'] Converting video from %s to %s, Destination: ' % (information['ext'], self._preferedformat) +outpath) - self.run_ffmpeg(path, outpath, []) + self.run_ffmpeg(path, outpath, self._opts) information['filepath'] = outpath information['format'] = self._preferedformat information['ext'] = self._preferedformat