From bb0ee1984032a6932269b595fa071dc1e75c64e6 Mon Sep 17 00:00:00 2001 From: AGSPhoenix Date: Thu, 6 Mar 2014 21:26:53 -0500 Subject: [PATCH] Warn user if DASH offers higher quality Currently, this message is printed whenever _real_extract() is called; still looking for a way to only print when we're downloading. --- youtube_dl/extractor/youtube.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/youtube_dl/extractor/youtube.py b/youtube_dl/extractor/youtube.py index 518249b40..93a9c7f97 100644 --- a/youtube_dl/extractor/youtube.py +++ b/youtube_dl/extractor/youtube.py @@ -1431,6 +1431,14 @@ class YoutubeIE(YoutubeBaseInfoExtractor, SubtitlesInfoExtractor): self.report_warning(u'Skipping DASH manifest: %s' % e, video_id) self._sort_formats(formats) + + #Warn user if DASH offers higher qualities + for format in formats: + if 'height' in format: + if format['height'] > formats[-1]['height']: + self.to_screen("Warning: youtube-dl can't automatically download the best version of this video.") + self.to_screen("For more information: https://goo.gl/ychwk3") + break return { 'id': video_id,