From 9ecf3eee2da8ed0acb90ad2107d42f6b1eecb01e Mon Sep 17 00:00:00 2001 From: Kyle Date: Thu, 1 Aug 2019 10:19:49 +0900 Subject: [PATCH] Simplify example --- CONTRIBUTING.md | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1813f5473..d0e0a5637 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -375,22 +375,15 @@ Extracting variables is acceptable for reducing code duplication and improving r Correct: ```python -return self.playlist_result( - [self._parse_brightcove_metadata(vid, vid.get('id'), headers) - for vid in json_data.get('videos', []) if vid.get('id')], - json_data.get('id'), json_data.get('name'), - json_data.get('description')) +title = self._html_search_regex(r'([^<]+)', webpage, 'title') ``` Incorrect: ```python -id = json_data.get('id') - -return self.playlist_result( - [self._parse_brightcove_metadata(vid, vid.get('id'), headers) - for vid in json_data.get('videos', []) if vid.get('id')], - id, json_data.get('name'), json_data.get('description')) +TITLE_RE = r'([^<]+)' +# ...some lines of code... +title = self._html_search_regex(TITLE_RE, webpage, 'title') ``` ### Collapse fallbacks