From 56ee4893e7f7c2127413ee3dea1f36e37fa2c8d4 Mon Sep 17 00:00:00 2001 From: Parmjit Virk Date: Tue, 5 Sep 2017 22:34:09 -0500 Subject: [PATCH 1/5] [nbc:NBCSportsVPlayer] Corrected video URL --- youtube_dl/extractor/nbc.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/youtube_dl/extractor/nbc.py b/youtube_dl/extractor/nbc.py index 62db70b43..f100321d5 100644 --- a/youtube_dl/extractor/nbc.py +++ b/youtube_dl/extractor/nbc.py @@ -134,7 +134,8 @@ class NBCSportsVPlayerIE(InfoExtractor): def _real_extract(self, url): video_id = self._match_id(url) webpage = self._download_webpage(url, video_id) - theplatform_url = self._og_search_video_url(webpage) + theplatform_url = self._og_search_video_url(webpage).replace( + 'vplayer.nbcsports.com', 'player.theplatform.com') return self.url_result(theplatform_url, 'ThePlatform') From d52d151b2c6374bdbe401d67b321b5588e7a0bb9 Mon Sep 17 00:00:00 2001 From: Parmjit Virk Date: Tue, 5 Sep 2017 22:49:04 -0500 Subject: [PATCH 2/5] [nbc:NBCSportsVPlayer] Updated tests --- youtube_dl/extractor/nbc.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/youtube_dl/extractor/nbc.py b/youtube_dl/extractor/nbc.py index f100321d5..167b4921a 100644 --- a/youtube_dl/extractor/nbc.py +++ b/youtube_dl/extractor/nbc.py @@ -109,18 +109,18 @@ class NBCSportsVPlayerIE(InfoExtractor): _VALID_URL = r'https?://vplayer\.nbcsports\.com/(?:[^/]+/)+(?P[0-9a-zA-Z_]+)' _TESTS = [{ - 'url': 'https://vplayer.nbcsports.com/p/BxmELC/nbcsports_share/select/9CsDKds0kvHI', + 'url': 'http://vplayer.nbcsports.com/p/BxmELC/chicago_embed/select/media/u4xMi3ngFKsS', 'info_dict': { - 'id': '9CsDKds0kvHI', - 'ext': 'flv', - 'description': 'md5:df390f70a9ba7c95ff1daace988f0d8d', - 'title': 'Tyler Kalinoski hits buzzer-beater to lift Davidson', - 'timestamp': 1426270238, - 'upload_date': '20150313', + 'id': 'u4xMi3ngFKsS', + 'ext': 'mp4', + 'description': 'md5:8fb3edf07c77cc5901c5f37fa019f87c', + 'title': 'Cubs PGL: Who needs to step up in Contreras\' absence', + 'timestamp': 1502319595, + 'upload_date': '20170809', 'uploader': 'NBCU-SPORTS', } }, { - 'url': 'http://vplayer.nbcsports.com/p/BxmELC/nbc_embedshare/select/_hqLjQ95yx8Z', + 'url': 'https://vplayer.nbcsports.com/p/BxmELC/nbcsports_embed/select/media/qyc_v6mfDyWv', 'only_matching': True, }] From 1b82a3ee2068bb41bbc2995ef1fe314fb0f56976 Mon Sep 17 00:00:00 2001 From: Parmjit Virk Date: Mon, 18 Sep 2017 00:34:39 -0500 Subject: [PATCH 3/5] [nbc:NBCSportsVPlayer] Applied requested fixes for PR #14134 --- youtube_dl/extractor/nbc.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/youtube_dl/extractor/nbc.py b/youtube_dl/extractor/nbc.py index 167b4921a..59ffa7362 100644 --- a/youtube_dl/extractor/nbc.py +++ b/youtube_dl/extractor/nbc.py @@ -109,18 +109,18 @@ class NBCSportsVPlayerIE(InfoExtractor): _VALID_URL = r'https?://vplayer\.nbcsports\.com/(?:[^/]+/)+(?P[0-9a-zA-Z_]+)' _TESTS = [{ - 'url': 'http://vplayer.nbcsports.com/p/BxmELC/chicago_embed/select/media/u4xMi3ngFKsS', + 'url': 'https://vplayer.nbcsports.com/p/BxmELC/nbcsports_embed/select/9CsDKds0kvHI', 'info_dict': { - 'id': 'u4xMi3ngFKsS', + 'id': '9CsDKds0kvHI', 'ext': 'mp4', - 'description': 'md5:8fb3edf07c77cc5901c5f37fa019f87c', - 'title': 'Cubs PGL: Who needs to step up in Contreras\' absence', - 'timestamp': 1502319595, - 'upload_date': '20170809', + 'description': 'md5:df390f70a9ba7c95ff1daace988f0d8d', + 'title': 'Tyler Kalinoski hits buzzer-beater to lift Davidson', + 'timestamp': 1426270238, + 'upload_date': '20150313', 'uploader': 'NBCU-SPORTS', } }, { - 'url': 'https://vplayer.nbcsports.com/p/BxmELC/nbcsports_embed/select/media/qyc_v6mfDyWv', + 'url': 'http://vplayer.nbcsports.com/p/BxmELC/chicago_embed/select/media/u4xMi3ngFKsS', 'only_matching': True, }] From 0bb39c3c7a3f5fc252b16898496f80c59a498785 Mon Sep 17 00:00:00 2001 From: Parmjit Virk Date: Tue, 19 Sep 2017 17:35:14 -0500 Subject: [PATCH 4/5] [nbc:NBCSportsVPlayer] Applied second requested fixes for PR #14134 --- youtube_dl/extractor/nbc.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/youtube_dl/extractor/nbc.py b/youtube_dl/extractor/nbc.py index 59ffa7362..f0f1984bc 100644 --- a/youtube_dl/extractor/nbc.py +++ b/youtube_dl/extractor/nbc.py @@ -108,7 +108,7 @@ class NBCIE(AdobePassIE): class NBCSportsVPlayerIE(InfoExtractor): _VALID_URL = r'https?://vplayer\.nbcsports\.com/(?:[^/]+/)+(?P[0-9a-zA-Z_]+)' - _TESTS = [{ + _TEST = { 'url': 'https://vplayer.nbcsports.com/p/BxmELC/nbcsports_embed/select/9CsDKds0kvHI', 'info_dict': { 'id': '9CsDKds0kvHI', @@ -119,10 +119,7 @@ class NBCSportsVPlayerIE(InfoExtractor): 'upload_date': '20150313', 'uploader': 'NBCU-SPORTS', } - }, { - 'url': 'http://vplayer.nbcsports.com/p/BxmELC/chicago_embed/select/media/u4xMi3ngFKsS', - 'only_matching': True, - }] + } @staticmethod def _extract_url(webpage): From 6ed8f9ae49ce7bcb1e2320c60017860e143e3019 Mon Sep 17 00:00:00 2001 From: Parmjit Virk Date: Tue, 19 Sep 2017 22:33:44 -0500 Subject: [PATCH 5/5] [nbc:NBCSportsVPlayer] Applied third requested fixes for PR #14134 --- youtube_dl/extractor/nbc.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/youtube_dl/extractor/nbc.py b/youtube_dl/extractor/nbc.py index f0f1984bc..836a41f06 100644 --- a/youtube_dl/extractor/nbc.py +++ b/youtube_dl/extractor/nbc.py @@ -108,7 +108,7 @@ class NBCIE(AdobePassIE): class NBCSportsVPlayerIE(InfoExtractor): _VALID_URL = r'https?://vplayer\.nbcsports\.com/(?:[^/]+/)+(?P[0-9a-zA-Z_]+)' - _TEST = { + _TESTS = [{ 'url': 'https://vplayer.nbcsports.com/p/BxmELC/nbcsports_embed/select/9CsDKds0kvHI', 'info_dict': { 'id': '9CsDKds0kvHI', @@ -119,7 +119,10 @@ class NBCSportsVPlayerIE(InfoExtractor): 'upload_date': '20150313', 'uploader': 'NBCU-SPORTS', } - } + }, { + 'url': 'https://vplayer.nbcsports.com/p/BxmELC/nbcsports_embed/select/media/_hqLjQ95yx8Z', + 'only_matching': True, + }] @staticmethod def _extract_url(webpage):