refactor: replace size() == 0 with isEmpty()

This commit is contained in:
Breno A.
2024-06-09 08:54:37 -03:00
Unverified
parent da61d30f44
commit ef58ab3e5a
54 changed files with 89 additions and 91 deletions
@@ -69,7 +69,7 @@ public final class AchievementCommand implements CommandHandler {
@Override
public void execute(Player sender, Player targetPlayer, List<String> args) {
if (args.size() < 1) {
if (args.isEmpty()) {
this.sendUsageMessage(sender);
return;
}
@@ -88,7 +88,7 @@ public final class AchievementCommand implements CommandHandler {
private void grant(
Player sender, Player targetPlayer, Achievements achievements, List<String> args) {
if (args.size() < 1) {
if (args.isEmpty()) {
this.sendUsageMessage(sender);
}
@@ -109,7 +109,7 @@ public final class AchievementCommand implements CommandHandler {
private void revoke(
Player sender, Player targetPlayer, Achievements achievements, List<String> args) {
if (args.size() < 1) {
if (args.isEmpty()) {
this.sendUsageMessage(sender);
}
@@ -19,7 +19,7 @@ public final class AnnounceCommand implements CommandHandler {
@Override
public void execute(Player sender, Player targetPlayer, List<String> args) {
var manager = Grasscutter.getGameServer().getAnnouncementSystem();
if (args.size() < 1) {
if (args.isEmpty()) {
sendUsageMessage(sender);
return;
}
@@ -51,7 +51,7 @@ public final class ClearCommand implements CommandHandler {
// Extract any tagged int arguments (e.g. "lv90", "x100", "r5")
parseIntParameters(args, param, intCommandHandlers);
if (args.size() < 1) {
if (args.isEmpty()) {
sendUsageMessage(sender);
return;
}
@@ -16,7 +16,7 @@ public final class EnterDungeonCommand implements CommandHandler {
@Override
public void execute(Player sender, Player targetPlayer, List<String> args) {
if (args.size() < 1) {
if (args.isEmpty()) {
sendUsageMessage(sender);
return;
}
@@ -279,7 +279,7 @@ public final class GiveCommand implements CommandHandler {
parseIntParameters(args, param, intCommandHandlers);
// At this point, first remaining argument MUST be itemId/avatarId
if (args.size() < 1) {
if (args.isEmpty()) {
sendUsageMessage(sender); // Reachable if someone does `/give lv90` or similar
throw new IllegalArgumentException();
}
@@ -362,7 +362,7 @@ public final class GiveCommand implements CommandHandler {
@Override
public void execute(Player sender, Player targetPlayer, List<String> args) {
if (args.size() < 1) { // *No args*
if (args.isEmpty()) { // *No args*
sendUsageMessage(sender);
return;
}
@@ -19,14 +19,14 @@ public final class ListCommand implements CommandHandler {
Map<Integer, Player> playersMap = Grasscutter.getGameServer().getPlayers();
boolean needUID = false;
if (args.size() > 0) {
if (!args.isEmpty()) {
needUID = args.get(0).equals("uid");
}
CommandHandler.sendMessage(
sender, translate(sender, "commands.list.success", playersMap.size()));
if (playersMap.size() != 0) {
if (!playersMap.isEmpty()) {
StringBuilder playerSet = new StringBuilder();
boolean finalNeedUID = needUID;
@@ -18,7 +18,7 @@ public final class ResetConstCommand implements CommandHandler {
@Override
public void execute(Player sender, Player targetPlayer, List<String> args) {
if (args.size() > 0 && args.get(0).equalsIgnoreCase("all")) {
if (!args.isEmpty() && args.get(0).equalsIgnoreCase("all")) {
targetPlayer.getAvatars().forEach(this::resetConstellation);
CommandHandler.sendMessage(sender, translate(sender, "commands.resetConst.reset_all"));
} else {
@@ -69,7 +69,7 @@ public final class SendMailCommand implements CommandHandler {
} else {
MailBuilder mailBuilder = mailBeingConstructed.get(senderId);
if (args.size() >= 1) {
if (!args.isEmpty()) {
switch (args.get(0).toLowerCase()) {
case "stop" -> {
mailBeingConstructed.remove(senderId);
@@ -17,7 +17,7 @@ public final class SendMessageCommand implements CommandHandler {
@Override
public void execute(Player sender, Player targetPlayer, List<String> args) {
if (args.size() == 0) {
if (args.isEmpty()) {
sendUsageMessage(sender);
return;
}
@@ -17,7 +17,7 @@ import java.util.List;
public final class SetConstCommand implements CommandHandler {
@Override
public void execute(Player sender, Player targetPlayer, List<String> args) {
if (args.size() < 1) {
if (args.isEmpty()) {
sendUsageMessage(sender);
return;
}
@@ -49,7 +49,7 @@ public final class SpawnCommand implements CommandHandler {
parseIntParameters(args, param, intCommandHandlers);
// At this point, first remaining argument MUST be the id and the rest the pos
if (args.size() < 1) {
if (args.isEmpty()) {
sendUsageMessage(sender); // Reachable if someone does `/give lv90` or similar
throw new IllegalArgumentException();
}
@@ -27,7 +27,7 @@ public final class TalentCommand implements CommandHandler {
@Override
public void execute(Player sender, Player targetPlayer, List<String> args) {
if (args.size() < 1) {
if (args.isEmpty()) {
sendUsageMessage(sender);
return;
}