Merge unstable into development (#2173)

* Remove more scene synchronized

* Fix worktop options not appearing

* Format code [skip actions]

* Fix delay with server tasks

* Format code [skip actions]

* Fully fix fairy clock (#2146)

* Fix scene transition

* fully fix fairy clock

* Re-add call to `Player#updatePlayerGameTime`

* Format code [skip actions]

* Initialize the script loader in `ResourceLoader#loadAll`

* Fix region removal checking

* Format code [skip actions]

* Use Lombok's `EqualsAndHashCode` for comparing scene regions

* Format code [skip actions]

* Move 'invalid gather object' to `trace`

* Add more information to the 'unknown condition handler' message

* Move invalid ability action to trace

* Make `KcpTunnel` public

* Validate the NPC being talked to

* Format code [skip actions]

* NPCs are not spawned server side; change logic to handle it

* Format code [skip actions]

* unload scene when there are no players (#2147)

* unload scene when there are no players

* Update src/main/java/emu/grasscutter/game/world/Scene.java

Co-authored-by: Magix <27646710+KingRainbow44@users.noreply.github.com>

---------

Co-authored-by: Magix <27646710+KingRainbow44@users.noreply.github.com>

* Check if a command should be copied or HTTP should be used

* Lint Code [skip actions]

* Fix character names rendering incorrectly

* Add basic troubleshooting command

* Implement handbook teleporting

also a few formatting changes and sort data by logical sense

* Fix listener `ConcurrentModificationException` issue

* Add color change to `Join the Community!`

* Lint Code [skip actions]

* Make clickable buttons appear clickable

* Remove 'Mechanicus' entities from the list of entities

* Format code [skip actions]

* Fix going back returning a blank screen

* Implement entity spawning

* Add setting level to entity card

* Add support for 'plain text' mode

* Make descriptions of objects scrollable

* Lint Code [skip actions]

* Format code [skip actions]

* Change the way existing hooks work

* Format code [skip actions]

* Upgrade Javalin to 5.5.0 & Fix project warnings

* Upgrade logging libraries

* Fix gacha mappings static file issue

* Add temporary backwards compatability for `ServerHelper`

* Format code [skip actions]

* Remove artifact signatures from VCS

* Fix forge queue data protocol definition

* Run `spotlessApply`

* Format code [skip actions]

* Download data required for building artifacts

* Add call for Facebook logins

* Add the wiki page as a submodule

* Format code [skip actions]

* Update translation (#2150)

* Update translation

* Update translation

* Separate the dispatch and game servers (pt. 1)

gacha is still broken, handbook still needs to be done

* Format code [skip actions]

* Separate the dispatch and game servers (pt. 2)

this commit fixes the gacha page

* Add description for '/troubleshoot'

* Set default avatar talent level to 10

* Separate the dispatch and game servers (pt. 3)

implement handbook across servers!

* Format code [skip actions]

* Update GitHub Actions to use 'download-file' over 'wget'

* Gm handbook lmao (#2149)

* Fix font issue

* Fix avatars

* Fix text overflow in commands

* Fix virtualized lists and items page 😭😭

* magix why 💀

* use hover style in all minicards

* button

* remove console.log

* lint

* Add icons

* magix asked

* Fix overflow padding issue

* Fix achievement text overflow

* remove icons from repo

* Change command icon

* Add the wiki page as a submodule

* total magix moment

* fix text overflow in commands

* Fix discord button

* Make text scale on Minicard

* import icons and font from another source

* Add hover effects to siebar buttons

* move font and readme to submodule repo

* Make data folder a submodule

* import icons and font from data submodule

* Update README.md

* total magix moment

* magix moment v2

* submodule change

* Import `.webp` files

* Resize `HomeButton`

* Fix 'Copy Command' reappearing after changing pages

---------

Co-authored-by: KingRainbow44 <kobedo11@gmail.com>

* Lint Code [skip actions]

* Download data for the build, not for the lint

* format imports

this is really just to see if build handbook works kek

* Implement proper handbook authentication (pt. 1)

* Implement proper handbook authentication (pt. 2)

* Format code [skip actions]

* Add quest data dumping for the handbook

* Change colors to fit _something suitable_

* Format code [skip actions]

* Fix force pushing to branches after linting

* Fix logic of `SetPlayerPropReq`

* Move more group loading to `trace`

* Add handbook IP authentication in hybrid mode

* Fix player level up not displaying on the client properly

* Format code [skip actions]

* Fix game time locking

* Format code [skip actions]

* Update player properties

* Format code [skip actions]

* Move `warn`s for groups to `debug`

* Fix player pausing

* Move more logs to `trace`

* Use `removeItemById` for deleting items via quests

* Clean up logger more

* Pause in-game time when the world is paused

* Format code [skip actions]

* More player property documentation

* Multi-threaded resource loading

* Format code [skip actions]

* Add quest widgets

* Add quests page (basic impl.)

* Add/fix colors

also fix tailwind

* Remove banned packets

client modifications already perform the job of blocking malicious packets from being executed, no point in having this if self-windy is wanted

* Re-add `BeginCameraSceneLookNotify`

* Fix being unable to attack (#2157)

* Add `PlayerOpenChestEvent`

* Add methods to get players from the server

* Add static methods to register an event handler

* Add `PlayerEnterDungeonEvent`

* Remove legacy documentation from `PlayerMoveEvent`

* Add `PlayerChatEvent`

* Add defaults to `Position`

* Clean up `.utils`

* Revert `Multi-threaded resource loading`

* Fix changing target UID when talking to the server

* Lint Code [skip actions]

* Format code [skip actions]

* fix NPC talk triggering main quest in 46101 (#2158)

Make it so that only talks where the param matches the talkId are checked.

* Format code [skip actions]

* Partially fix Chasing Shadows (#2159)

* Partially fix Chasing Shadows

* Go ahead and move it before the return before Magix tells me to.

* Format code [skip actions]

* Bring back period lol (#2160)

* Disable SNI for the HTTPS server

* Add `EntityCreationEvent`

* Add initial startup message

this is so the server appears like its preparing to start

* Format code [skip actions]

* Enable debug mode for plugin loggers if enabled for the primary logger

* Add documentation about `WorldAreaConfigData`

* Make more fields in excels accessible

* Remove deprecated fields from `GetShopRsp`

* Run `spotlessApply` on definitions

* Add `PlayerEnterAreaEvent`

* Optimize event calls

* Fix event invokes

* Format code [skip actions]

* Remove manual autofinish for main quests. (#2162)

* Add world areas to the textmap cache

* Format code [skip actions]

* Don't overdefine variables in extended classes (#2163)

* Add dumper for world areas

* Format code [skip actions]

* instantiate personalLineList (#2165)

* Fix protocol definitions

thank you Nazrin! (+ hiro for raw definitions)

* Fix the background color leaking from the character widget

* Change HTML spacing to 2 spaces

* Implement hiding widgets

* Change scrollbar to a vibrant color

* Add _some_ scaling to the home buttons and its text

* Build the handbook with Gradle

* Fix the 'finer details' with the handbook UI

* Lint Code [skip actions]

* Fix target destination for the Gradle-built handbook

* Implement fetching a player across servers & Add a chainable JsonObject

useful for plugins! might be used in grasscutter eventually

* Fix GitHub actions

* Fix event calling & canceling

* Run `spotlessApply`

* Rename fields (might be wrong)

* Add/update all/more protocol definitions

* Add/update all/more protocol definitions

* Remove outdated packet

* Fix protocol definitions

* Format code [skip actions]

* Implement some lua variables for less console spam (#2172)

* Implement some lua variables for less console spam

* Add GetHostQuestState

This fixes some chapter 3 stuff.

* Format code [skip actions]

* Fix merge import

* Format code [skip actions]

* Fully fix fairy clock for real this time (#2167)

* Fully fix fairy clock For real this time

* Make it so relogging keeps the time lock state.

* Refactor out questLockTime

* Per Hartie, the client packet needs to be changed too

* Update src/main/java/emu/grasscutter/game/world/World.java

Co-authored-by: Magix <27646710+KingRainbow44@users.noreply.github.com>

* Update src/main/java/emu/grasscutter/server/packet/recv/HandlerClientLockGameTimeNotify.java

* Remove all code not needed to get clock working

---------

Co-authored-by: Magix <27646710+KingRainbow44@users.noreply.github.com>

* Implement a proper ability system (#2166)

* Apply fix `21dec2fe`

* Apply fix `89d01d5f`

* Apply fix `d900f154`

this one was already implemented; updated to use call from previous commit

* Ability changing commit

TODO: change info to debug

* Remove use of deprecated methods/fields

* Temp commit v2
(Adding LoseHP and some fixes)

* Oopsie

* Probably fix monster battle

* Fix issue with reflecting into fields

* Fix some things

* Fix ability names for 3.6 resources

* Improve logging

---------

Co-authored-by: StartForKiller <jesussanz2003@gmail.com>

* Format code [skip actions]

* Add system for sending messages between servers

* Format some code

* Remove protocol definitions from Spotless

* Default debug to false; enable with `-debug`

* Implement completely useless global value copying

* HACK: Return the avatar which holds the weapon when the weapon is referred to by ID

* Add properties to `AbilityModifier`

* Change the way HTML is served after authentication

* Use thread executors to speed up the database loading process

* Format code [skip actions]

* Add system for setting handbook address and port

* Lint Code [skip actions]

* Format code [skip actions]

* Fix game-related data not saving

* Format code [skip actions]

* Fix handbook server details

* Lint Code [skip actions]

* Format code [skip actions]

* Use the headers provided by a context to get the IP address

should acknowledge #1975

* Format code [skip actions]

* Move more logs to `trace`

* Format code [skip actions]

* more trace

* Fix something and implement weapon entities

* Format code [skip actions]

* Fix `EntityWeapon`

* Remove deprecated API & Fix resource checking

* Fix unnecessary warning for first-time setup

* Implement handbook request limiting

* Format code [skip actions]

* Fix new avatar weapons being null

* Format code [skip actions]

* Fix issue with 35303 being un-completable & Try to fix fulfilled quest conditions being met

* Load activity config on server startup

* Require plugins to specify an API version and match with the server

* Add default open state ignore list

* Format code [skip actions]

* Quick fix for questing, needs more investigation
This would make the questing work again

* Remove existing hack for 35303

* Fix ignored open states from being set

* Format code [skip actions]

* fix the stupidest bug ive ever seen

* Optimize player kicking on server close

* Format code [skip actions]

* Re-add hack to fix 35303

* Update GitHub actions

* Format code [skip actions]

* Potentially fix issues with regions

* Download additional handbook data

* Revert "Potentially fix issues with regions"

This reverts commit 84e3823695.

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: scooterboo <lewasite@yahoo.com>
Co-authored-by: Tesutarin <105267106+Tesutarin@users.noreply.github.com>
Co-authored-by: Scald <104459145+Arikatsu@users.noreply.github.com>
Co-authored-by: StartForKiller <jesussanz2003@gmail.com>

src/main/java/emu/grasscutter/server/http/handlers/GachaHandler.java

@@ -1,91 +1,78 @@
 package emu.grasscutter.server.http.handlers;
 
+import static emu.grasscutter.utils.lang.Language.translate;
+
+import com.google.gson.JsonObject;
 import emu.grasscutter.Grasscutter;
 import emu.grasscutter.database.DatabaseHelper;
-import emu.grasscutter.game.Account;
-import emu.grasscutter.game.gacha.GachaBanner;
-import emu.grasscutter.game.gacha.GachaSystem;
 import emu.grasscutter.game.player.Player;
 import emu.grasscutter.server.http.Router;
+import emu.grasscutter.utils.DispatchUtils;
 import emu.grasscutter.utils.FileUtils;
 import emu.grasscutter.utils.Utils;
 import io.javalin.Javalin;
 import io.javalin.http.ContentType;
 import io.javalin.http.Context;
-import io.javalin.http.staticfiles.Location;
-import lombok.Getter;
-
 import java.io.IOException;
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.util.Arrays;
 import java.util.LinkedHashSet;
-import java.util.Set;
+import lombok.Getter;
 
-import static emu.grasscutter.utils.Language.translate;
-
-/**
- * Handles all gacha-related HTTP requests.
- */
+/** Handles all gacha-related HTTP requests. */
 public final class GachaHandler implements Router {
-    @Getter private static final Path gachaMappingsPath = FileUtils.getDataUserPath("gacha/mappings.js");
+    @Getter
+    private static final Path gachaMappingsPath = FileUtils.getDataUserPath("gacha/mappings.js");
+
     @Deprecated(forRemoval = true)
     public static final String gachaMappings = gachaMappingsPath.toString();
 
-    @Override public void applyRoutes(Javalin javalin) {
-        javalin.get("/gacha", GachaHandler::gachaRecords);
-        javalin.get("/gacha/details", GachaHandler::gachaDetails);
-
-        javalin._conf.addSinglePageRoot("/gacha/mappings", gachaMappingsPath.toString(), Location.EXTERNAL);  // TODO: This ***must*** be changed to take the Path not a String. This might involve upgrading Javalin.
-    }
-
     private static void gachaRecords(Context ctx) {
-        String sessionKey = ctx.queryParam("s");
-        Account account = DatabaseHelper.getAccountBySessionKey(sessionKey);
+        var sessionKey = ctx.queryParam("s");
+        var account = DatabaseHelper.getAccountBySessionKey(sessionKey);
         if (account == null) {
-            ctx.status(403).result("Requested account was not found");
-            return;
-        }
-        Player player = Grasscutter.getGameServer().getPlayerByAccountId(account.getId());
-        if (player == null) {
-            ctx.status(403).result("No player associated with requested account");
+            ctx.status(403).result("Requested account was not found.");
             return;
         }
 
+        // Get page and gacha type.
         int page = 0, gachaType = 0;
-        if (ctx.queryParam("p") != null)
-            page = Integer.parseInt(ctx.queryParam("p"));
-        if (ctx.queryParam("gachaType") != null)
-            gachaType = Integer.parseInt(ctx.queryParam("gachaType"));
 
-        String records = DatabaseHelper.getGachaRecords(player.getUid(), page, gachaType).toString();
-        long maxPage = DatabaseHelper.getGachaRecordsMaxPage(player.getUid(), page, gachaType);
+        var pageStr = ctx.queryParam("p");
+        if (pageStr != null) page = Integer.parseInt(pageStr);
 
-        String template = new String(FileUtils.read(FileUtils.getDataPath("gacha/records.html")), StandardCharsets.UTF_8)
-            .replace("{{REPLACE_RECORDS}}", records)
-            .replace("{{REPLACE_MAXPAGE}}", String.valueOf(maxPage))
-            .replace("{{TITLE}}", translate(player, "gacha.records.title"))
-            .replace("{{DATE}}", translate(player, "gacha.records.date"))
-            .replace("{{ITEM}}", translate(player, "gacha.records.item"))
-            .replace("{{LANGUAGE}}", Utils.getLanguageCode(account.getLocale()));
+        var gachaTypeStr = ctx.queryParam("gachaType");
+        if (gachaTypeStr != null) gachaType = Integer.parseInt(gachaTypeStr);
+
+        // Make request to dispatch server.
+        var data = DispatchUtils.fetchGachaRecords(account.getId(), page, gachaType);
+        var records = data.get("records").getAsJsonArray();
+        var maxPage = data.get("maxPage").getAsLong();
+
+        var locale = account.getLocale();
+        var template =
+                new String(
+                                FileUtils.read(FileUtils.getDataPath("gacha/records.html")), StandardCharsets.UTF_8)
+                        .replace("'{{REPLACE_RECORDS}}'", records.toString())
+                        .replace("'{{REPLACE_MAXPAGE}}'", String.valueOf(maxPage))
+                        .replace("{{TITLE}}", translate(locale, "gacha.records.title"))
+                        .replace("{{DATE}}", translate(locale, "gacha.records.date"))
+                        .replace("{{ITEM}}", translate(locale, "gacha.records.item"))
+                        .replace("{{LANGUAGE}}", Utils.getLanguageCode(account.getLocale()));
         ctx.contentType(ContentType.TEXT_HTML);
         ctx.result(template);
     }
 
     private static void gachaDetails(Context ctx) {
-        Path detailsTemplate = FileUtils.getDataPath("gacha/details.html");
-        String sessionKey = ctx.queryParam("s");
-        Account account = DatabaseHelper.getAccountBySessionKey(sessionKey);
+        var detailsTemplate = FileUtils.getDataPath("gacha/details.html");
+        var sessionKey = ctx.queryParam("s");
+        var account = DatabaseHelper.getAccountBySessionKey(sessionKey);
         if (account == null) {
             ctx.status(403).result("Requested account was not found");
             return;
         }
-        Player player = Grasscutter.getGameServer().getPlayerByAccountId(account.getId());
-        if (player == null) {
-            ctx.status(403).result("No player associated with requested account");
-            return;
-        }
 
         String template;
         try {
@@ -97,37 +84,54 @@ public final class GachaHandler implements Router {
         }
 
         // Add translated title etc. to the page.
-        template = template.replace("{{TITLE}}", translate(player, "gacha.details.title"))
-                .replace("{{AVAILABLE_FIVE_STARS}}", translate(player, "gacha.details.available_five_stars"))
-                .replace("{{AVAILABLE_FOUR_STARS}}", translate(player, "gacha.details.available_four_stars"))
-                .replace("{{AVAILABLE_THREE_STARS}}", translate(player, "gacha.details.available_three_stars"))
-                .replace("{{LANGUAGE}}", Utils.getLanguageCode(account.getLocale()));
+        var locale = account.getLocale();
+        template =
+                template
+                        .replace("{{TITLE}}", translate(locale, "gacha.details.title"))
+                        .replace(
+                                "{{AVAILABLE_FIVE_STARS}}", translate(locale, "gacha.details.available_five_stars"))
+                        .replace(
+                                "{{AVAILABLE_FOUR_STARS}}", translate(locale, "gacha.details.available_four_stars"))
+                        .replace(
+                                "{{AVAILABLE_THREE_STARS}}",
+                                translate(locale, "gacha.details.available_three_stars"))
+                        .replace("{{LANGUAGE}}", Utils.getLanguageCode(account.getLocale()));
 
         // Get the banner info for the banner we want.
-        int scheduleId = Integer.parseInt(ctx.queryParam("scheduleId"));
-        GachaSystem manager = Grasscutter.getGameServer().getGachaSystem();
-        GachaBanner banner = manager.getGachaBanners().get(scheduleId);
+        var scheduleIdStr = ctx.queryParam("scheduleId");
+        if (scheduleIdStr == null) {
+            ctx.status(400).result("Missing scheduleId parameter");
+            return;
+        }
+
+        var scheduleId = Integer.parseInt(scheduleIdStr);
+        var manager = Grasscutter.getGameServer().getGachaSystem();
+        var banner = manager.getGachaBanners().get(scheduleId);
 
         // Add 5-star items.
-        Set<String> fiveStarItems = new LinkedHashSet<>();
+        var fiveStarItems = new LinkedHashSet<String>();
 
         Arrays.stream(banner.getRateUpItems5()).forEach(i -> fiveStarItems.add(Integer.toString(i)));
-        Arrays.stream(banner.getFallbackItems5Pool1()).forEach(i -> fiveStarItems.add(Integer.toString(i)));
-        Arrays.stream(banner.getFallbackItems5Pool2()).forEach(i -> fiveStarItems.add(Integer.toString(i)));
+        Arrays.stream(banner.getFallbackItems5Pool1())
+                .forEach(i -> fiveStarItems.add(Integer.toString(i)));
+        Arrays.stream(banner.getFallbackItems5Pool2())
+                .forEach(i -> fiveStarItems.add(Integer.toString(i)));
 
         template = template.replace("{{FIVE_STARS}}", "[" + String.join(",", fiveStarItems) + "]");
 
         // Add 4-star items.
-        Set<String> fourStarItems = new LinkedHashSet<>();
+        var fourStarItems = new LinkedHashSet<String>();
 
         Arrays.stream(banner.getRateUpItems4()).forEach(i -> fourStarItems.add(Integer.toString(i)));
-        Arrays.stream(banner.getFallbackItems4Pool1()).forEach(i -> fourStarItems.add(Integer.toString(i)));
-        Arrays.stream(banner.getFallbackItems4Pool2()).forEach(i -> fourStarItems.add(Integer.toString(i)));
+        Arrays.stream(banner.getFallbackItems4Pool1())
+                .forEach(i -> fourStarItems.add(Integer.toString(i)));
+        Arrays.stream(banner.getFallbackItems4Pool2())
+                .forEach(i -> fourStarItems.add(Integer.toString(i)));
 
         template = template.replace("{{FOUR_STARS}}", "[" + String.join(",", fourStarItems) + "]");
 
         // Add 3-star items.
-        Set<String> threeStarItems = new LinkedHashSet<>();
+        var threeStarItems = new LinkedHashSet<String>();
         Arrays.stream(banner.getFallbackItems3()).forEach(i -> threeStarItems.add(Integer.toString(i)));
         template = template.replace("{{THREE_STARS}}", "[" + String.join(",", threeStarItems) + "]");
 
@@ -135,4 +139,30 @@ public final class GachaHandler implements Router {
         ctx.contentType(ContentType.TEXT_HTML);
         ctx.result(template);
     }
+
+    /**
+     * Fetches the gacha records for the specified player.
+     *
+     * @param player The player to fetch the records for.
+     * @param response The response to write to.
+     * @param page The page to fetch.
+     * @param type The gacha type to fetch.
+     */
+    public static void fetchGachaRecords(Player player, JsonObject response, int page, int type) {
+        var playerId = player.getUid();
+        var records = DatabaseHelper.getGachaRecords(playerId, page, type).toString();
+        var maxPage = DatabaseHelper.getGachaRecordsMaxPage(playerId, page, type);
+
+        // Finish the response.
+        response.addProperty("retcode", 0);
+        response.addProperty("records", records);
+        response.addProperty("maxPage", maxPage);
+    }
+
+    @Override
+    public void applyRoutes(Javalin javalin) {
+        javalin.get("/gacha", GachaHandler::gachaRecords);
+        javalin.get("/gacha/details", GachaHandler::gachaDetails);
+        javalin.get("/gacha/mappings", ctx -> ctx.result(FileUtils.read(gachaMappingsPath.toString())));
+    }
 }